From: David Wei <dw@davidwei.uk>
To: Ziwei Xiao <ziweixiao@google.com>
Cc: netdev@vger.kernel.org, jeroendb@google.com,
pkaligineedi@google.com, shailend@google.com,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, willemb@google.com, hramamurthy@google.com,
rushilg@google.com, jfraker@google.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 4/5] gve: Add flow steering adminq commands
Date: Mon, 20 May 2024 10:27:01 -0700 [thread overview]
Message-ID: <713182b5-5fda-48a7-8947-8dc3d10c42b1@davidwei.uk> (raw)
In-Reply-To: <CAG-FcCPnrN8Wodn0+UYPJ4XpvDpVyhCzvGPx2CnDit8adwKYSg@mail.gmail.com>
On 2024-05-09 17:18, Ziwei Xiao wrote:
> On Tue, May 7, 2024 at 11:24 PM David Wei <dw@davidwei.uk> wrote:
>>
>> On 2024-05-07 15:59, Ziwei Xiao wrote:
[...]
>>> +/* Flow-steering related definitions */
>>> +enum gve_adminq_flow_rule_cfg_opcode {
>>> + GVE_RULE_ADD = 0,
>>> + GVE_RULE_DEL = 1,
>>> + GVE_RULE_RESET = 2,
>>> +};
>>
>> Could these be more descriptive?
>>
> Could you be more specific on which needs to be improved? Is the enum
> name or the field name?
Sorry for the late response.
The enum field names. GVE_RULE_x is too sparse for me; what rule? To
match the rest of the file maybe something like GVE_FLOW_RULE_CFG_x.
next prev parent reply other threads:[~2024-05-20 17:27 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-07 22:59 [PATCH net-next 0/5] gve: Add flow steering support Ziwei Xiao
2024-05-07 22:59 ` [PATCH net-next 1/5] gve: Add adminq mutex lock Ziwei Xiao
2024-05-08 12:07 ` Markus Elfring
2024-05-07 22:59 ` [PATCH net-next 2/5] gve: Add adminq extended command Ziwei Xiao
2024-05-08 12:17 ` Markus Elfring
2024-05-11 14:32 ` Simon Horman
2024-05-07 22:59 ` [PATCH net-next 3/5] gve: Add flow steering device option Ziwei Xiao
2024-05-08 5:32 ` David Wei
2024-05-10 0:18 ` Ziwei Xiao
2024-05-08 5:34 ` [PATCH net-next 2/5] gve: Add adminq extended command David Wei
2024-05-10 0:17 ` Ziwei Xiao
2024-05-07 22:59 ` [PATCH net-next 4/5] gve: Add flow steering adminq commands Ziwei Xiao
2024-05-08 6:24 ` David Wei
2024-05-10 0:18 ` Ziwei Xiao
2024-05-20 17:27 ` David Wei [this message]
2024-05-08 13:23 ` Markus Elfring
2024-05-08 14:24 ` kernel test robot
2024-05-07 22:59 ` [PATCH net-next 5/5] gve: Add flow steering ethtool support Ziwei Xiao
2024-05-08 14:09 ` Markus Elfring
2024-05-10 0:19 ` Ziwei Xiao
2024-05-10 3:16 ` Jakub Kicinski
2024-05-10 6:45 ` Markus Elfring
2024-05-11 14:45 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=713182b5-5fda-48a7-8947-8dc3d10c42b1@davidwei.uk \
--to=dw@davidwei.uk \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hramamurthy@google.com \
--cc=jeroendb@google.com \
--cc=jfraker@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pkaligineedi@google.com \
--cc=rushilg@google.com \
--cc=shailend@google.com \
--cc=willemb@google.com \
--cc=ziweixiao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).