From: Nicolas Dichtel <nicolas.dichtel@6wind.com>
To: Fernando Fernandez Mancera <fmancera@suse.de>, netdev@vger.kernel.org
Cc: linux-kselftest@vger.kernel.org, horms@kernel.org,
pabeni@redhat.com, kuba@kernel.org, edumazet@google.com,
davem@davemloft.net, idosch@nvidia.com, dsahern@kernel.org
Subject: Re: [PATCH 2/3 net-next v3] ipv4: handle devconf post-set actions on netlink updates
Date: Tue, 5 May 2026 14:46:10 +0200 [thread overview]
Message-ID: <714a61c4-1b86-4c8c-9149-499efe5de68a@6wind.com> (raw)
In-Reply-To: <20260504123143.6284-2-fmancera@suse.de>
Le 04/05/2026 à 14:31, Fernando Fernandez Mancera a écrit :
> When IPv4 device configuration parameters are updated via netlink, the
> kernel currently only updates the value. This bypasses several
> post-modification actions that occur when these same parameters are
> updated via sysctl, such as flushing the routing cache or emitting
> RTM_NEWNETCONF notifications.
>
> This patch addresses the inconsistency by calling the
> devinet_conf_post_set() helper inside inet_set_link_af(). If a flush is
> required, we defer it until the netlink attribute parsing loop
> completes.
>
> This ensures consistent behavior and side-effects for devconf changes,
> regardless of whether they are initiated via sysctl or netlink.
>
> Signed-off-by: Fernando Fernandez Mancera <fmancera@suse.de>
Reviewed-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
next prev parent reply other threads:[~2026-05-05 12:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-04 12:31 [PATCH 1/3 net-next v3] ipv4: centralize devconf sysctl handling Fernando Fernandez Mancera
2026-05-04 12:31 ` [PATCH 2/3 net-next v3] ipv4: handle devconf post-set actions on netlink updates Fernando Fernandez Mancera
2026-05-05 12:46 ` Nicolas Dichtel [this message]
2026-05-04 12:31 ` [PATCH 3/3 net-next v3] selftests: net: add test for IPv4 devconf netlink notifications Fernando Fernandez Mancera
2026-05-04 15:08 ` Fernando Fernandez Mancera
2026-05-05 12:46 ` [PATCH 1/3 net-next v3] ipv4: centralize devconf sysctl handling Nicolas Dichtel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=714a61c4-1b86-4c8c-9149-499efe5de68a@6wind.com \
--to=nicolas.dichtel@6wind.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=fmancera@suse.de \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox