From: Maxime Chevallier <maxime.chevallier@bootlin.com>
To: Simon Horman <horms@kernel.org>
Cc: davem@davemloft.net, "Andrew Lunn" <andrew@lunn.ch>,
"Jakub Kicinski" <kuba@kernel.org>,
"Eric Dumazet" <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Russell King" <linux@armlinux.org.uk>,
"Heiner Kallweit" <hkallweit1@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
thomas.petazzoni@bootlin.com,
"Christophe Leroy" <christophe.leroy@csgroup.eu>,
"Herve Codina" <herve.codina@bootlin.com>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Vladimir Oltean" <vladimir.oltean@nxp.com>,
"Köry Maincent" <kory.maincent@bootlin.com>,
"Marek Behún" <kabel@kernel.org>,
"Oleksij Rempel" <o.rempel@pengutronix.de>,
"Nicolò Veronese" <nicveronese@gmail.com>,
mwojtas@chromium.org,
"Romain Gantois" <romain.gantois@bootlin.com>,
"Daniel Golle" <daniel@makrotopia.org>,
"Dimitri Fedrau" <dimitri.fedrau@liebherr.com>
Subject: Re: [PATCH net-next v3 05/11] net: phy: Create SFP phy_port before registering usptream
Date: Tue, 3 Feb 2026 19:09:23 +0100 [thread overview]
Message-ID: <7150d811-df6a-488d-a7d8-96aec01365db@bootlin.com> (raw)
In-Reply-To: <aYI1zd6Iddcdt6xc@horms.kernel.org>
Hi Simon,
On 03/02/2026 18:52, Simon Horman wrote:
>> - if (!ret && phydev->sfp_bus)
>> - ret = phy_setup_sfp_port(phydev);
>> + ret = sfp_bus_add_upstream(bus, phydev, &sfp_phydev_ops);
>> + sfp_bus_put(bus);
>> +
>> + if (ret && port) {
>
> Hi Maxime,
>
> If bus is NULL then port will not be set here.
Arg... I though smatch was running in the NIPA ingst-mdir script, but I
was wrong :(
I'll address that in V5 as the problme is still in V4, thank you for the
report
Maxime
next prev parent reply other threads:[~2026-02-03 18:09 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-01 15:12 [PATCH net-next v3 00/11] net: phy_port: SFP modules representation and phy_port listing Maxime Chevallier
2026-02-01 15:12 ` [PATCH net-next v3 01/11] net: phy: phy_port: Correctly recompute the port's linkmodes Maxime Chevallier
2026-02-03 17:58 ` [net-next,v3,01/11] " Simon Horman
2026-02-03 18:13 ` Maxime Chevallier
2026-02-01 15:12 ` [PATCH net-next v3 02/11] net: phy: phy_link_topology: Add a helper for opportunistic alloc Maxime Chevallier
2026-02-01 15:12 ` [PATCH net-next v3 03/11] net: phy: phy_link_topology: Track ports in phy_link_topology Maxime Chevallier
2026-02-03 18:02 ` [net-next,v3,03/11] " Simon Horman
2026-02-03 18:11 ` Maxime Chevallier
2026-02-01 15:12 ` [PATCH net-next v3 04/11] net: phylink: Register a phy_port for MAC-driven SFP busses Maxime Chevallier
2026-02-01 15:12 ` [PATCH net-next v3 05/11] net: phy: Create SFP phy_port before registering usptream Maxime Chevallier
2026-02-03 17:52 ` Simon Horman
2026-02-03 18:09 ` Maxime Chevallier [this message]
2026-02-09 16:25 ` Simon Horman
2026-02-03 18:03 ` [net-next,v3,05/11] " Simon Horman
2026-02-03 18:12 ` Maxime Chevallier
2026-02-01 15:12 ` [PATCH net-next v3 06/11] net: phy: Represent PHY-less SFP modules with phy_port Maxime Chevallier
2026-02-03 19:57 ` [net-next,v3,06/11] " Simon Horman
2026-02-01 15:12 ` [PATCH net-next v3 07/11] net: phylink: " Maxime Chevallier
2026-02-01 15:12 ` [PATCH net-next v3 08/11] net: phy: phy_port: Store information about a MII port's vacant state Maxime Chevallier
2026-02-01 15:12 ` [PATCH net-next v3 09/11] net: phy: phy_link_topology: Add a helper to retrieve ports Maxime Chevallier
2026-02-01 15:12 ` [PATCH net-next v3 10/11] netlink: specs: Add ethernet port listing with ethtool Maxime Chevallier
2026-02-03 17:55 ` Simon Horman
2026-02-03 18:14 ` Maxime Chevallier
2026-02-01 15:12 ` [PATCH net-next v3 11/11] net: ethtool: Introduce ethtool command to list ports Maxime Chevallier
2026-02-02 7:56 ` [PATCH net-next v3 00/11] net: phy_port: SFP modules representation and phy_port listing Maxime Chevallier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7150d811-df6a-488d-a7d8-96aec01365db@bootlin.com \
--to=maxime.chevallier@bootlin.com \
--cc=andrew@lunn.ch \
--cc=christophe.leroy@csgroup.eu \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=dimitri.fedrau@liebherr.com \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=herve.codina@bootlin.com \
--cc=hkallweit1@gmail.com \
--cc=horms@kernel.org \
--cc=kabel@kernel.org \
--cc=kory.maincent@bootlin.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mwojtas@chromium.org \
--cc=netdev@vger.kernel.org \
--cc=nicveronese@gmail.com \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=romain.gantois@bootlin.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox