From: Gregory Rose <gvrose8192@gmail.com>
To: Pravin Shelar <pshelar@ovn.org>
Cc: David Miller <davem@davemloft.net>,
ap420073@gmail.com, ovs dev <dev@openvswitch.org>,
Linux Kernel Network Developers <netdev@vger.kernel.org>
Subject: Re: [ovs-dev] [PATCH net-next] net: openvswitch: do not update max_headroom if new headroom is equal to old headroom
Date: Thu, 11 Jul 2019 16:55:22 -0700 [thread overview]
Message-ID: <715a1bc4-abd4-90bb-2e2f-1a2da8fd861d@gmail.com> (raw)
In-Reply-To: <CAOrHB_CLRYC_AFgDhzPGadXDob4hO1Q7Eorqm4bZjMJLV3cMBQ@mail.gmail.com>
On 7/11/2019 2:07 PM, Pravin Shelar wrote:
> I was bit busy for last couple of days. I will finish review by EOD today.
>
> Thanks,
> Pravin.
net-next is closed anyway so no rush, but thanks!
- Greg
>
> On Mon, Jul 8, 2019 at 4:22 PM Gregory Rose <gvrose8192@gmail.com> wrote:
>>
>>
>> On 7/8/2019 4:18 PM, Gregory Rose wrote:
>>> On 7/8/2019 4:08 PM, David Miller wrote:
>>>> From: Taehee Yoo <ap420073@gmail.com>
>>>> Date: Sat, 6 Jul 2019 01:08:09 +0900
>>>>
>>>>> When a vport is deleted, the maximum headroom size would be changed.
>>>>> If the vport which has the largest headroom is deleted,
>>>>> the new max_headroom would be set.
>>>>> But, if the new headroom size is equal to the old headroom size,
>>>>> updating routine is unnecessary.
>>>>>
>>>>> Signed-off-by: Taehee Yoo <ap420073@gmail.com>
>>>> I'm not so sure about the logic here and I'd therefore like an OVS
>>>> expert
>>>> to review this.
>>> I'll review and test it and get back. Pravin may have input as well.
>>>
>> Err, adding Pravin.
>>
>> - Greg
>>
>>> Thanks,
>>>
>>> - Greg
>>>
>>>> Thanks.
>>>> _______________________________________________
>>>> dev mailing list
>>>> dev@openvswitch.org
>>>> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
next prev parent reply other threads:[~2019-07-11 23:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-05 16:08 [PATCH net-next] net: openvswitch: do not update max_headroom if new headroom is equal to old headroom Taehee Yoo
2019-07-08 23:08 ` David Miller
2019-07-08 23:18 ` [ovs-dev] " Gregory Rose
2019-07-08 23:22 ` Gregory Rose
2019-07-11 21:07 ` Pravin Shelar
2019-07-11 23:55 ` Gregory Rose [this message]
2019-07-12 16:18 ` Gregory Rose
2019-07-12 22:18 ` David Miller
2019-07-12 23:11 ` Gregory Rose
2019-07-15 18:15 ` Pravin Shelar
2019-07-16 12:28 ` Taehee Yoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=715a1bc4-abd4-90bb-2e2f-1a2da8fd861d@gmail.com \
--to=gvrose8192@gmail.com \
--cc=ap420073@gmail.com \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=netdev@vger.kernel.org \
--cc=pshelar@ovn.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).