From: Florian Fainelli <f.fainelli@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>, David Miller <davem@davemloft.net>
Cc: netdev <netdev@vger.kernel.org>,
Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Subject: Re: [PATCH net-next 2/2] net: dsa: mv88e6xxx: Free ATU/VTU irq only when there is chip irq
Date: Mon, 15 Jan 2018 14:54:22 -0800 [thread overview]
Message-ID: <715ef97b-128e-3feb-a3e9-f6963cf0be49@gmail.com> (raw)
In-Reply-To: <1516056358-4852-3-git-send-email-andrew@lunn.ch>
On 01/15/2018 02:45 PM, Andrew Lunn wrote:
> We only register the ATU and VTU irq when we have a chip level IRQ.
> In the error path, we should only attempt to remove the ATU and VTU
> irq if we also have a chip level IRQ.
>
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> ---
> drivers/net/dsa/mv88e6xxx/chip.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c
> index 54cb00a27408..eb328bade225 100644
> --- a/drivers/net/dsa/mv88e6xxx/chip.c
> +++ b/drivers/net/dsa/mv88e6xxx/chip.c
> @@ -3999,9 +3999,11 @@ static int mv88e6xxx_probe(struct mdio_device *mdiodev)
> out_mdio:
> mv88e6xxx_mdios_unregister(chip);
> out_g1_vtu_prob_irq:
> - mv88e6xxx_g1_vtu_prob_irq_free(chip);
> + if (chip->irq > 0)
> + mv88e6xxx_g1_vtu_prob_irq_free(chip);
Why not move this check to mv88e6xxx_g1_vtu_prob_irq_free() and make it
a no-op if chip->irq <= 0?
--
Florian
next prev parent reply other threads:[~2018-01-15 22:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-15 22:45 [PATCH net-next 0/2] ATU and VTU irq fixes Andrew Lunn
2018-01-15 22:45 ` [PATCH net-next 1/2] net: dsa: mv88e6xxx: Return error from irq_find_mapping() Andrew Lunn
2018-01-15 22:45 ` [PATCH net-next 2/2] net: dsa: mv88e6xxx: Free ATU/VTU irq only when there is chip irq Andrew Lunn
2018-01-15 22:54 ` Florian Fainelli [this message]
2018-01-15 23:02 ` Andrew Lunn
2018-01-16 20:18 ` [PATCH net-next 0/2] ATU and VTU irq fixes David Miller
2018-01-16 20:23 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=715ef97b-128e-3feb-a3e9-f6963cf0be49@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).