Re: [PATCH 5/7] esp6: Switch to new AEAD interface

Herbert Xu
2015-05-26T08:18:06Z

On Tue, May 26, 2015 at 10:15:37AM +0200, Stephan Mueller wrote:
>
> I fully understand that. But the current patch set that we discuss modifies
> the IPSEC implementation of esp_ouput to use the new interface. Therefore, to
> use rfc4106(gcm(aes)) *with* the IV generator (i.e. to get the old removed
> givcrypt logic), the AEAD cipher handle must be allocated with
> seqniv(rfc4106(gcm(aes))), would it not?
>
> Therfore, I would assume that user space has to use the new cipher name when
> setting up IPSEC that uses the new interface.

No I have not exposed IV generation to user-space. If and when we
do that we can easily set a default IV generator.

This is all in the patch series that you're responding. So please
actually read it rather than making assumptions :)

Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt