[PATCH 0/2] crypto: Use tmpl->create when registering geniv

Herbert Xu
2015-05-22T21:54:31Z

On Fri, May 22, 2015 at 11:04:39PM +0200, Stephan Mueller wrote:
> Am Freitag, 22. Mai 2015, 22:59:34 schrieb Stephan Mueller:
>
> Hi Stephan,
>
> > Am Freitag, 22. Mai 2015, 16:31:04 schrieb Herbert Xu:
> >
> > Hi Herbert,
> >
> > > This patch makes use of the new AEAD interface which uses a single
> > > SG list instead of separate lists for the AD and plain text.
> >
> > Using an up-to date tree with the full set of patches of this patch set, I
> > get the following oops.
> >
> > It can easily be reproduced by using [1]: go to libkcapi/test/ and compile
> > with make. Then execute ./test.sh
> >
> > [1] http://www.chronox.de/libkcapi.html
>
> Note, gcm(aes) looks good. Only rfc4106(gcm(aes)) causes the crash.

Thanks for the report!

The crash is because ablkcipher/aead are still using tmpl->alloc
and I forgot about them.

The following two patches will fix the crash by making them call
tmpl->create if it is set.

Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt