From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87D7EC4332F for ; Tue, 18 Oct 2022 19:33:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229535AbiJRTc7 (ORCPT ); Tue, 18 Oct 2022 15:32:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50676 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229665AbiJRTc6 (ORCPT ); Tue, 18 Oct 2022 15:32:58 -0400 X-Greylist: delayed 90 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Tue, 18 Oct 2022 12:32:55 PDT Received: from omta037.useast.a.cloudfilter.net (omta037.useast.a.cloudfilter.net [44.202.169.36]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F04F96CD0D for ; Tue, 18 Oct 2022 12:32:55 -0700 (PDT) Received: from eig-obgw-6013a.ext.cloudfilter.net ([10.0.30.177]) by cmsmtp with ESMTP id kmI3oF54e7krOksJ9ouWaE; Tue, 18 Oct 2022 19:31:23 +0000 Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with ESMTP id ksJ5oo4k3s4voksJ6o8o6o; Tue, 18 Oct 2022 19:31:20 +0000 X-Authority-Analysis: v=2.4 cv=Cf4bWZnl c=1 sm=1 tr=0 ts=634eff08 a=1YbLdUo/zbTtOZ3uB5T3HA==:117 a=VLn1U4HDsV/kFU42pi1uTw==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=IkcTkHD0fZMA:10 a=Qawa6l4ZSaYA:10 a=wYkD_t78qR0A:10 a=cak1eodxRRWiubympP0A:9 a=QEXdDO2ut3YA:10 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=embeddedor.com; s=default; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=B8sItrIzPT1FhGdQ0ENveK914e997Na/QHZvsstLhtM=; b=EtFXKgE3/C7QhFoXgAIqcn+mHq n0jpJ1yc89SZFk3QRIYWQbQFlkZdKqHQVNmC25NtWS58DqjR9hP8X7VDgpmbZ5z9sPBo78pcP7MAk lTqwTU8S2sLegbh6wRASDikI9wq5d5HT/2cXKFlzchDXxggEfq6ayJ5Ilamr1vBho8EU0ef/ogJKM YBMxKWwKUop1rMOwjLtEFiD+UVGKYS2AwP+8ex28C0DBva22ITFJsYwS3LH59OxtuaMrUIgVfpCrx iWHsqSFZKD3WenFiqyFkTrKo3lMyMEXfdNeKKlDBWZrd9FWi4zDzBNtc+T6o3Kz1deV1SN+Xh7ImB mfQVRQ2Q==; Received: from [187.184.159.238] (port=8860 helo=[192.168.0.24]) by gator4166.hostgator.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.95) (envelope-from ) id 1oksJ4-0006S8-1O; Tue, 18 Oct 2022 14:31:18 -0500 Message-ID: <71935a08-e9d3-5f9e-5b9a-7847bd38b756@embeddedor.com> Date: Tue, 18 Oct 2022 14:31:12 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH 2/6][next] cfg80211: Avoid clashing function prototypes Content-Language: en-US To: Kees Cook , "Gustavo A. R. Silva" Cc: Johannes Berg , Kalle Valo , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org References: <291de76bc7cd5c21dc2f2471382ab0caaf625b22.1666038048.git.gustavoars@kernel.org> <202210171939.61FFBE79A7@keescook> From: "Gustavo A. R. Silva" In-Reply-To: <202210171939.61FFBE79A7@keescook> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 187.184.159.238 X-Source-L: No X-Exim-ID: 1oksJ4-0006S8-1O X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: ([192.168.0.24]) [187.184.159.238]:8860 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 5 X-Org: HG=hgshared;ORG=hostgator; X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfCRWv1AtnVa/+i8w3/8VKIOt4CyST3vA3uwYkV0ljA/IVRoG5A1mSN2ZV4xGlgYam1AWag9Po4qfx7tBJWJD1oM7I0yJSylE/kl6EzVc/s72ed+wD3rO 25bvcAZ8qP2zx4+UYAaGNhvJtNUSWww5A+J33Sc747+1J+OBspxXM12XWLdRxsODvjUMR8M3HgAD6jwlUUPmz5EYdFbGAg6FcEY= Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 10/17/22 21:41, Kees Cook wrote: >> >> static const iw_handler orinoco_handler[] = { >> IW_HANDLER(SIOCSIWCOMMIT, orinoco_ioctl_commit), >> - IW_HANDLER(SIOCGIWNAME, (iw_handler)cfg80211_wext_giwname), >> + IW_HANDLER(SIOCGIWNAME, cfg80211_wext_giwname), > > This hunk should be in the orinoco patch, I think? I just didn't want to have this huge patch touching multiple different files. That's why I decided to split it up into three separate patches. But yeah; now it seems like a good idea to merge patches 1 to 3 into just a single patch. > > >> [...] >> + [IW_IOCTL_IDX(SIOCGIWRETRY)] = cfg80211_wext_giwretry, > > The common practice seems to be to use IW_HANDLER instead of open-coding > it like this. > > IW_HANDLER(SIOCGIWRETRY, cfg80211_wext_giwretry), Yeah; I forget this after reverting Sami's changes: 32fc4a9ad56f ("cfg80211: fix callback type mismatches in wext-compat") I'll fix it up. :) Thanks for the feedback! -- Gustavo