From: Christian Riesch <christian.riesch@omicron.at>
To: Jon Ringle <jon@ringle.org>
Cc: linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
rafael.j.wysocki@intel.com, netdev@vger.kernel.org,
davinci-linux-open-source@linux.davincidsp.com
Subject: Re: Ethernet controller not starting
Date: Tue, 04 Mar 2014 10:06:50 +0100 [thread overview]
Message-ID: <71F7AD3B89A7BF1E126CB3B1@C9882B18C00BA04428877CD4> (raw)
[cc'ed netdev and davinci-linux-open-source]
--On March 03, 2014 19:39 -0500 Jon Ringle <jon@ringle.org> wrote:
> On Mon, Mar 3, 2014 at 6:43 PM, Rafael J. Wysocki <rjw@rjwysocki.net>
> wrote:
>> On Monday, March 03, 2014 02:41:01 PM Jon Ringle wrote:
>>> I'm working on porting an ARM board from linux-3.10 to linux-3.12 (now
>>> the latest LTS kernel).
>>> I found that Ethernet controller on the board no longer comes up on
>>> linux-3.12. I was able to bisect the issue I'm having to the following
>>> commit:
>>>
>>> > 45f0a85c8258741d11bda25c0a5669c06267204a is the first bad commit
>>> > commit 45f0a85c8258741d11bda25c0a5669c06267204a
>>> > Author: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>>> > Date: Mon Jun 3 21:49:52 2013 +0200
>>> >
>>> > PM / Runtime: Rework the "runtime idle" helper routine
>>> >
>>> > The "runtime idle" helper routine, rpm_idle(), currently ignores
>>> > return values from .runtime_idle() callbacks executed by it.
>>> > However, it turns out that many subsystems use
>>> > pm_generic_runtime_idle() which checks the return value of the
>>> > driver's callback and executes pm_runtime_suspend() for the
>>> > device unless that value is not 0. If that logic is moved to
>>> > rpm_idle() instead, pm_generic_runtime_idle() can be dropped
>>> > and its users will not need any .runtime_idle() callbacks any
>>> > more.
>>> >
>>> > Moreover, the PCI, SCSI, and SATA subsystems' .runtime_idle()
>>> > routines, pci_pm_runtime_idle(), scsi_runtime_idle(), and
>>> > ata_port_runtime_idle(), respectively, as well as a few drivers'
>>> > ones may be simplified if rpm_idle() calls rpm_suspend() after
>>> > 0 has been returned by the .runtime_idle() callback executed by
>>> > it.
>>> >
>>> > To reduce overall code bloat, make the changes described above.
>>> >
>>> > Tested-by: Mika Westerberg <mika.westerberg@linux.intel.com>
>>> > Tested-by: Kevin Hilman <khilman@linaro.org>
>>> > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>>> > Acked-by: Kevin Hilman <khilman@linaro.org>
>>> > Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org>
>>> > Acked-by: Alan Stern <stern@rowland.harvard.edu>
>>>
>>> Can anyone offer any suggestions on what I should be looking for to
>>> fix this on my board?
>>
>> Any pointers to the driver in question?
>
> drivers/net/ethernet/ti/davinci_emac.c
>
Hi Jon,
I have successfully used the davinci_emac driver on a custom board with an
AM1808 SoC with Kernel 3.13 a few weeks ago. So at least 3.13 should work.
Did you try more recent kernel versions than 3.12?
> I also get the following output:
>
> Starting Network Manager Wait Online...
> [ 30.946509] davinci_mdio davinci_mdio.0: resetting idled controller
> [ 30.953220] net net0: attached PHY driver [Generic PHY]
> (mii_bus:phy_addr=davinci_mdio-0:00, id=7c0f1)
> [ 30.962938] IPv6: ADDRCONF(NETDEV_UP): net0: link is not ready
> [ 31.082087] genirq: Flags mismatch irq 33. 00000000 (net0) vs.
> 00000000 (net0)
Is it correct that this warning can only appear in case of shared
interrupts? See kernel/irq/manage.c. Since we don't use shared interrupts
here: Are you sure your board configuration is correct with regard to emac
interrupts? Is your configuration using device tree or not (my
configuration is a none-devicetree one)? I also wonder why your network
device is net0, on my board it's eth0, maybe this triggers some bug?
Christian
next reply other threads:[~2014-03-04 9:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-04 9:06 Christian Riesch [this message]
[not found] ` <CAMwGMjwtZVPVaENWqNODPqkM4jAAOsLPrz8_xzRBgGP6_-_usQ@mail.gmail.com>
2014-03-04 12:34 ` Fwd: Ethernet controller not starting Jon Ringle
2014-03-04 14:06 ` Christian Riesch
[not found] ` <09FBC53C1B46AC96B6483AA4@172.22.2.41>
2014-03-04 15:08 ` Jon Ringle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=71F7AD3B89A7BF1E126CB3B1@C9882B18C00BA04428877CD4 \
--to=christian.riesch@omicron.at \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=jon@ringle.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox