Re: [PATCH net-next v4 3/3] net: libwx: support vf per-queue statistics via ethtool -S

[Paolo Abeni <pabeni@redhat.com>]

On 6/11/26 5:18 PM, Simon Horman wrote:
> On Thu, Jun 11, 2026 at 04:46:08PM +0800, mengyuanlou@net-swift.com wrote:
>>> 2026年6月11日 14:48，Simon Horman <horms@kernel.org> 写道：
>>> On Mon, Jun 08, 2026 at 06:39:46PM +0800, Mengyuan Lou wrote:

>>>> +static inline unsigned int wx_stats_len(const struct wx *wx)
>>>> +{
>>>> + struct net_device *netdev = wx->netdev;
>>>
>>> netdev seems unused.
>>>
>>> Flagged by AI-generated review on sashiko.dev 
>>
>>
>> #define WX_NUM_RX_QUEUES netdev->num_tx_queues
>> #define WX_NUM_TX_QUEUES netdev->num_tx_queues
>>
>> #define WX_QUEUE_STATS_LEN ( \
>> (WX_NUM_TX_QUEUES + WX_NUM_RX_QUEUES) * \
>> (sizeof(struct wx_queue_stats) / sizeof(u64)))
>>
>> netdev is used.
> 
> Thanks, sorry for missing that.
> 
> Perhaps it would clearer if WX_NUM_RX_QUEUES and WX_NUM_TX_QUEUES took
> arguments. 

I agree with the above. It looks like there are very few users of such
macros. My suggestion is to include a patch adding the argument (or
entirely dropping/open-coding them) in the next iteration of this series.

/P