* [PATCH net] sctp: avoid compiler warning on implicit fallthru
@ 2018-01-11 16:22 Marcelo Ricardo Leitner
2018-01-12 20:14 ` Neil Horman
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Marcelo Ricardo Leitner @ 2018-01-11 16:22 UTC (permalink / raw)
To: netdev; +Cc: linux-sctp, Neil Horman, Vlad Yasevich
These fall-through are expected.
Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
---
net/sctp/ipv6.c | 1 +
net/sctp/outqueue.c | 4 ++--
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/net/sctp/ipv6.c b/net/sctp/ipv6.c
index 3b18085e3b10253f3f81be7a6747b50ef9357db2..5d4c15bf66d26219415596598a1f72d29b63a798 100644
--- a/net/sctp/ipv6.c
+++ b/net/sctp/ipv6.c
@@ -826,6 +826,7 @@ static int sctp_inet6_af_supported(sa_family_t family, struct sctp_sock *sp)
case AF_INET:
if (!__ipv6_only_sock(sctp_opt2sk(sp)))
return 1;
+ /* fallthru */
default:
return 0;
}
diff --git a/net/sctp/outqueue.c b/net/sctp/outqueue.c
index 7d67feeeffc1e758ae4be4ef1ddaea23276d1f5e..c4ec99b2015002b273071e6fb1ec3c59c9f61154 100644
--- a/net/sctp/outqueue.c
+++ b/net/sctp/outqueue.c
@@ -918,9 +918,9 @@ static void sctp_outq_flush(struct sctp_outq *q, int rtx_timeout, gfp_t gfp)
break;
case SCTP_CID_ABORT:
- if (sctp_test_T_bit(chunk)) {
+ if (sctp_test_T_bit(chunk))
packet->vtag = asoc->c.my_vtag;
- }
+ /* fallthru */
/* The following chunks are "response" chunks, i.e.
* they are generated in response to something we
* received. If we are sending these, then we can
--
2.14.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH net] sctp: avoid compiler warning on implicit fallthru
2018-01-11 16:22 [PATCH net] sctp: avoid compiler warning on implicit fallthru Marcelo Ricardo Leitner
@ 2018-01-12 20:14 ` Neil Horman
2018-01-13 4:48 ` Xin Long
2018-01-15 18:58 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: Neil Horman @ 2018-01-12 20:14 UTC (permalink / raw)
To: Marcelo Ricardo Leitner; +Cc: netdev, linux-sctp, Vlad Yasevich
On Thu, Jan 11, 2018 at 02:22:06PM -0200, Marcelo Ricardo Leitner wrote:
> These fall-through are expected.
>
> Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
> ---
> net/sctp/ipv6.c | 1 +
> net/sctp/outqueue.c | 4 ++--
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/net/sctp/ipv6.c b/net/sctp/ipv6.c
> index 3b18085e3b10253f3f81be7a6747b50ef9357db2..5d4c15bf66d26219415596598a1f72d29b63a798 100644
> --- a/net/sctp/ipv6.c
> +++ b/net/sctp/ipv6.c
> @@ -826,6 +826,7 @@ static int sctp_inet6_af_supported(sa_family_t family, struct sctp_sock *sp)
> case AF_INET:
> if (!__ipv6_only_sock(sctp_opt2sk(sp)))
> return 1;
> + /* fallthru */
> default:
> return 0;
> }
> diff --git a/net/sctp/outqueue.c b/net/sctp/outqueue.c
> index 7d67feeeffc1e758ae4be4ef1ddaea23276d1f5e..c4ec99b2015002b273071e6fb1ec3c59c9f61154 100644
> --- a/net/sctp/outqueue.c
> +++ b/net/sctp/outqueue.c
> @@ -918,9 +918,9 @@ static void sctp_outq_flush(struct sctp_outq *q, int rtx_timeout, gfp_t gfp)
> break;
>
> case SCTP_CID_ABORT:
> - if (sctp_test_T_bit(chunk)) {
> + if (sctp_test_T_bit(chunk))
> packet->vtag = asoc->c.my_vtag;
> - }
> + /* fallthru */
> /* The following chunks are "response" chunks, i.e.
> * they are generated in response to something we
> * received. If we are sending these, then we can
> --
> 2.14.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sctp" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net] sctp: avoid compiler warning on implicit fallthru
2018-01-11 16:22 [PATCH net] sctp: avoid compiler warning on implicit fallthru Marcelo Ricardo Leitner
2018-01-12 20:14 ` Neil Horman
@ 2018-01-13 4:48 ` Xin Long
2018-01-15 18:58 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: Xin Long @ 2018-01-13 4:48 UTC (permalink / raw)
To: Marcelo Ricardo Leitner
Cc: network dev, linux-sctp, Neil Horman, Vlad Yasevich
On Fri, Jan 12, 2018 at 12:22 AM, Marcelo Ricardo Leitner
<marcelo.leitner@gmail.com> wrote:
> These fall-through are expected.
>
> Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
> ---
> net/sctp/ipv6.c | 1 +
> net/sctp/outqueue.c | 4 ++--
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/net/sctp/ipv6.c b/net/sctp/ipv6.c
> index 3b18085e3b10253f3f81be7a6747b50ef9357db2..5d4c15bf66d26219415596598a1f72d29b63a798 100644
> --- a/net/sctp/ipv6.c
> +++ b/net/sctp/ipv6.c
> @@ -826,6 +826,7 @@ static int sctp_inet6_af_supported(sa_family_t family, struct sctp_sock *sp)
> case AF_INET:
> if (!__ipv6_only_sock(sctp_opt2sk(sp)))
> return 1;
> + /* fallthru */
> default:
> return 0;
> }
> diff --git a/net/sctp/outqueue.c b/net/sctp/outqueue.c
> index 7d67feeeffc1e758ae4be4ef1ddaea23276d1f5e..c4ec99b2015002b273071e6fb1ec3c59c9f61154 100644
> --- a/net/sctp/outqueue.c
> +++ b/net/sctp/outqueue.c
> @@ -918,9 +918,9 @@ static void sctp_outq_flush(struct sctp_outq *q, int rtx_timeout, gfp_t gfp)
> break;
>
> case SCTP_CID_ABORT:
> - if (sctp_test_T_bit(chunk)) {
> + if (sctp_test_T_bit(chunk))
> packet->vtag = asoc->c.my_vtag;
> - }
> + /* fallthru */
> /* The following chunks are "response" chunks, i.e.
> * they are generated in response to something we
> * received. If we are sending these, then we can
> --
> 2.14.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sctp" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Reviewed-by: Xin Long <lucien.xin@gmail.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net] sctp: avoid compiler warning on implicit fallthru
2018-01-11 16:22 [PATCH net] sctp: avoid compiler warning on implicit fallthru Marcelo Ricardo Leitner
2018-01-12 20:14 ` Neil Horman
2018-01-13 4:48 ` Xin Long
@ 2018-01-15 18:58 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2018-01-15 18:58 UTC (permalink / raw)
To: marcelo.leitner; +Cc: netdev, linux-sctp, nhorman, vyasevich
From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Date: Thu, 11 Jan 2018 14:22:06 -0200
> These fall-through are expected.
>
> Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Applied, thank you.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-01-15 18:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-11 16:22 [PATCH net] sctp: avoid compiler warning on implicit fallthru Marcelo Ricardo Leitner
2018-01-12 20:14 ` Neil Horman
2018-01-13 4:48 ` Xin Long
2018-01-15 18:58 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).