From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-183.mta0.migadu.com (out-183.mta0.migadu.com [91.218.175.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 26F6F847C for ; Tue, 8 Oct 2024 01:40:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.183 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728351637; cv=none; b=Bcqbbiug/NmBKbpTLBe1EP8f1bB087YEUOPZ7pn1E9xN5/8l0RxymSOfsTVnyaC8mMCSU9Wv2hU7jAutnNCZSKbxw49DA+/AivWNf/nudRr3mv0P0iyw9csWui5N6/z/BdgmyQqTo/BIHqC5+kvUmSa1M2njo+7nQVH673slmms= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728351637; c=relaxed/simple; bh=B2GRuWWO+zkJJO3Yxi5A+sBodIFq92iiXD5DjhoPg0Y=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ZPhI9/0DVPNqRNp4tZdvY0+7hZyqhCt5maYOwii/+kfoWoNnvtNn94beYQfeI2Pio8Ys2UYMBcEcGWmabEp+Xt36sd9AGSsg67FCS+gHweOs16wGVbOUy4ifLxAJGFhdU/fF9k8tQ4YoCg1BONEXduE5vLzGVZyoQ/lzWMHvWCs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=vrcBEivz; arc=none smtp.client-ip=91.218.175.183 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="vrcBEivz" Message-ID: <72385fe9-e34d-4642-a62c-61083395c722@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1728351633; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=B2GRuWWO+zkJJO3Yxi5A+sBodIFq92iiXD5DjhoPg0Y=; b=vrcBEivz48gYUo8grTfiwdmnEIj4OAJH25XMI34C1Gq//D6JeUSyNKG2+tZCuZBUeILEcN yICNHYS7FZ7ITDq7IWb1dqVqV68FnGVhQCePuIWm66Gu62OZTZuhz3tbWrzvgYOqeeRqvq PUiZ9OhCiIhUze1rcGPmNnDsizW4GeU= Date: Mon, 7 Oct 2024 18:40:26 -0700 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH bpf-next v2 5/5] selftests/bpf: Extend netkit tests to validate skb meta data To: Daniel Borkmann Cc: razor@blackwall.org, kuba@kernel.org, jrife@google.com, tangchen.1@bytedance.com, bpf@vger.kernel.org, netdev@vger.kernel.org References: <20241004101335.117711-1-daniel@iogearbox.net> <20241004101335.117711-5-daniel@iogearbox.net> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Martin KaFai Lau In-Reply-To: <20241004101335.117711-5-daniel@iogearbox.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 10/4/24 3:13 AM, Daniel Borkmann wrote: > +void serial_test_tc_netkit_scrub_type(int scrub) nit. This can be static. Others lgtm. I can adjust before landing.