From: Saeed Mahameed <saeed@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>, davem@davemloft.net
Cc: netdev@vger.kernel.org, michael.chan@broadcom.com,
leon@kernel.org, ecree.xilinx@gmail.com,
habetsm.xilinx@gmail.com, f.fainelli@gmail.com, andrew@lunn.ch,
mkubecek@suse.cz, ariela@nvidia.com, corbet@lwn.net,
linux-doc@vger.kernel.org
Subject: Re: [PATCH net-next 3/6] ethtool: add FEC statistics
Date: Wed, 14 Apr 2021 23:25:43 -0700 [thread overview]
Message-ID: <723b2858c61898df02e57bb2aaa4c4b4b3c30c50.camel@kernel.org> (raw)
In-Reply-To: <20210414034454.1970967-4-kuba@kernel.org>
On Tue, 2021-04-13 at 20:44 -0700, Jakub Kicinski wrote:
> ethtool_link_ksettings *);
> + void (*get_fec_stats)(struct net_device *dev,
> + struct ethtool_fec_stats
> *fec_stats);
why void ? some drivers need to access the FW and it could be an old
FW/device where the fec stats are not supported.
and sometimes e.g. in mlx5 case FW can fail for FW related businesses
:)..
next prev parent reply other threads:[~2021-04-15 6:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-14 3:44 [PATCH net-next 0/6] ethtool: add standard FEC statistics Jakub Kicinski
2021-04-14 3:44 ` [PATCH net-next 1/6] ethtool: move ethtool_stats_init Jakub Kicinski
2021-04-14 3:44 ` [PATCH net-next 2/6] ethtool: fec_prepare_data() - jump to error handling Jakub Kicinski
2021-04-14 3:44 ` [PATCH net-next 3/6] ethtool: add FEC statistics Jakub Kicinski
2021-04-15 6:25 ` Saeed Mahameed [this message]
2021-04-15 15:21 ` Jakub Kicinski
2021-04-15 22:33 ` Saeed Mahameed
2021-04-14 3:44 ` [PATCH net-next 4/6] bnxt: implement ethtool::get_fec_stats Jakub Kicinski
2021-04-15 20:58 ` Michael Chan
2021-04-14 3:44 ` [PATCH net-next 5/6] sfc: ef10: " Jakub Kicinski
2021-04-19 12:39 ` Edward Cree
2021-04-14 3:44 ` [PATCH net-next 6/6] mlx5: " Jakub Kicinski
2021-04-15 6:37 ` Saeed Mahameed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=723b2858c61898df02e57bb2aaa4c4b4b3c30c50.camel@kernel.org \
--to=saeed@kernel.org \
--cc=andrew@lunn.ch \
--cc=ariela@nvidia.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=ecree.xilinx@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=habetsm.xilinx@gmail.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=michael.chan@broadcom.com \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).