From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF51FC433EF for ; Fri, 8 Jul 2022 12:34:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237987AbiGHMeb (ORCPT ); Fri, 8 Jul 2022 08:34:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55562 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237735AbiGHMea (ORCPT ); Fri, 8 Jul 2022 08:34:30 -0400 Received: from mailout-taastrup.gigahost.dk (mailout-taastrup.gigahost.dk [46.183.139.199]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6401B6EE9E; Fri, 8 Jul 2022 05:34:28 -0700 (PDT) Received: from mailout.gigahost.dk (mailout.gigahost.dk [89.186.169.112]) by mailout-taastrup.gigahost.dk (Postfix) with ESMTP id 1662F1887129; Fri, 8 Jul 2022 12:34:26 +0000 (UTC) Received: from smtp.gigahost.dk (smtp.gigahost.dk [89.186.169.109]) by mailout.gigahost.dk (Postfix) with ESMTP id 0BDBB25032B7; Fri, 8 Jul 2022 12:34:26 +0000 (UTC) Received: by smtp.gigahost.dk (Postfix, from userid 1000) id EE690A1E00AD; Fri, 8 Jul 2022 12:34:25 +0000 (UTC) X-Screener-Id: 413d8c6ce5bf6eab4824d0abaab02863e8e3f662 MIME-Version: 1.0 Date: Fri, 08 Jul 2022 14:34:25 +0200 From: netdev@kapio-technology.com To: Vladimir Oltean Cc: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, Andrew Lunn , Vivien Didelot , Florian Fainelli , Eric Dumazet , Paolo Abeni , Jiri Pirko , Ivan Vecera , Roopa Prabhu , Nikolay Aleksandrov , Shuah Khan , Daniel Borkmann , Ido Schimmel , linux-kernel@vger.kernel.org, bridge@lists.linux-foundation.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v4 net-next 3/6] drivers: net: dsa: add locked fdb entry flag to drivers In-Reply-To: <20220708115624.rrjzjtidlhcqczjv@skbuf> References: <20220707152930.1789437-1-netdev@kapio-technology.com> <20220707152930.1789437-4-netdev@kapio-technology.com> <20220708084904.33otb6x256huddps@skbuf> <20220708091550.2qcu3tyqkhgiudjg@skbuf> <20220708115624.rrjzjtidlhcqczjv@skbuf> User-Agent: Gigahost Webmail Message-ID: <723e2995314b41ff323272536ef27341@kapio-technology.com> X-Sender: netdev@kapio-technology.com Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2022-07-08 13:56, Vladimir Oltean wrote: > On Fri, Jul 08, 2022 at 11:50:33AM +0200, netdev@kapio-technology.com > wrote: >> On 2022-07-08 11:15, Vladimir Oltean wrote: >> > When the possibility for it to be true will exist, _all_ switchdev >> > drivers will need to be updated to ignore that (mlxsw, cpss, ocelot, >> > rocker, prestera, etc etc), not just DSA. And you don't need to >> > propagate the is_locked flag to all individual DSA sub-drivers when none >> > care about is_locked in the ADD_TO_DEVICE direction, you can just ignore >> > within DSA until needed otherwise. >> > >> >> Maybe I have it wrong, but I think that Ido requested me to send it to >> all >> the drivers, and have them ignore entries with is_locked=true ... > > I don't think Ido requested you to ignore is_locked from all DSA > drivers, but instead from all switchdev drivers maybe. Quite different. So without changing the signature on port_fdb_add(). If that is to avoid changing that signature, which needs to be changed anyhow for any switchcore driver to act on it, then my next patch set will change the signarure also as it is needed for creating dynamic ATU entries from userspace, which is needed to make the whole thing complete. As it is already done (with the is_locked to the drivers) and needed for future application, I would like Ido to comment on it before I take action. > > In any case I'm going to take a look at this patch set more closely and > run the selftest on my Marvell switch, but I can't do this today > unfortunately. I'll return with more comments. Yes :-)