From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 661E3320A0E for ; Tue, 17 Mar 2026 14:20:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=192.198.163.11 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773757230; cv=fail; b=fquLsDa03I6MFuKH1tFlSJLYbVWFcPZEJ+qeVFnLnWHX95lwDS7unfVzMwGFxC5LrHZa7I3nQwDvVv/fwqoKYfmuuK9h8GtwPejlzIdBI8A0lCyfsAoR2Jx7nGDtWgNjmKFbgY4X4dQQNM//9CnH7FfQ21s7sJFVwLbdSY2Y8Ig= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773757230; c=relaxed/simple; bh=Iv60vXvZHbR3T6ckugeVqGdK4LNJg2xC9poUp4Km1Y4=; h=Message-ID:Date:Subject:To:CC:References:From:In-Reply-To: Content-Type:MIME-Version; b=RrJ58bHK13rRdh+Ykvan+n0zu449PU2RNfkCFd+aKctyLrKgEWmnJ6wJeRSaxdUdmh8Se2pudyJ24NBoOkDPtyuG0gXQqs+SKZkH4Z3Sm/8TUFwVOSea9R2PijNpJaoI6DGpWJeh1d+9fTsNpx4lZyvzDoPR0oonMNRwoKwP+gM= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=AIMSYrG6; arc=fail smtp.client-ip=192.198.163.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="AIMSYrG6" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1773757228; x=1805293228; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=Iv60vXvZHbR3T6ckugeVqGdK4LNJg2xC9poUp4Km1Y4=; b=AIMSYrG6QlTOV78AT5DCIksHOxQCVNim1uzQT7Qh+/US8kYctMYqqP0W hNPCXh69QPVgomEhhMW0zuASapYPyph2wrfNHQMLDg7B1thFd+i6QFkAG ZV1sAfBbxQwhVEXM4XXg8WF3Pq6OpXk24kJi4mLjfRWsHeGYB5zfsQZuD FoRrkyWmOqA+Z282qalDO10uprwc8/KXaAuNkS+kPd0N5G9Eb5gXM/BrO Ujo6mDorKznxaCzIsvpS/ZMpsLprFYbS+3/3910Jzu6Eykf56cKB4Y8r5 rDGmkO8Gdk3qR7PSJpPx/KsBJ65M6aQtZ/POFx0mfK4xeSoQWGrGjJyNz g==; X-CSE-ConnectionGUID: cNbaStqHSGesCf/CgQZ+dQ== X-CSE-MsgGUID: qQJySloNSZSGVLgVZAA64w== X-IronPort-AV: E=McAfee;i="6800,10657,11732"; a="85417853" X-IronPort-AV: E=Sophos;i="6.23,124,1770624000"; d="scan'208";a="85417853" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Mar 2026 07:20:28 -0700 X-CSE-ConnectionGUID: wRVkKyfESjay5Mp1OOsiMA== X-CSE-MsgGUID: v3f3oawfTfWP+TjEmwOc/g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,124,1770624000"; d="scan'208";a="245303338" Received: from orsmsx903.amr.corp.intel.com ([10.22.229.25]) by fmviesa002.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Mar 2026 07:20:27 -0700 Received: from ORSMSX903.amr.corp.intel.com (10.22.229.25) by ORSMSX903.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Tue, 17 Mar 2026 07:20:26 -0700 Received: from ORSEDG903.ED.cps.intel.com (10.7.248.13) by ORSMSX903.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37 via Frontend Transport; Tue, 17 Mar 2026 07:20:26 -0700 Received: from PH0PR06CU001.outbound.protection.outlook.com (40.107.208.52) by edgegateway.intel.com (134.134.137.113) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Tue, 17 Mar 2026 07:20:25 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=KW+l6buEHxJlDlmdhxuCBiK2/I2MnzbfukKfMWGYeEjasI9/Kmo+bSmRyzvBgQzl3RXuBvuEyWtWIIv8/i82NA3p7rxjY/c6yopeA4EfCDWIQXlnCKIrP99TKW/pQe7Sm4XReDx2H+8VeyzZ2ZPeJKiGEqS5+hAo1LxjFPgNeyDIV9A6UXqf0pn+XjKEMrqJDfoW1nPH1f4dpjGFKJubK+NdeCKbq1oho020NYVMc8CHwVsaJaL2GYKBcaBFnmRAuQe5DrVr7+x5zCMGp9FM9s8eHBu1Bj+96yquf4uIYK3JBUJMTr4BzuVoO0oxZEWFoe4v3Z+76+mT++0Quoy9SQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=H0clfimYY3lytPJUqtuLTBXuz6qi3njrGZkNbiHg1lY=; b=KDCwPckjpQ4eqKr/02LSFkeEcLFDryy56QHwgk6rMyPjIlJOR6qz3NYc0VXNaanHSF84FRFisMu7IpeX0Omk5jnAXOKSgwZNM6x6tMJYHDA7/ii/u2lD/tjAGPwC7P6lSE+XGx1KJg4KAl/zRy5yfjGbUPb6qpBr0EtcCKJvkHzcxe4vSIxRkh9wzYMaG9aOf1G6a38yw/zQ2FcAMbLOKsXvlKFA/xfE4ZxDA1/HxMEWgkxngBOUj6jNmfibwm//7d3CwZzSjb9GqAP9Udtbz4EK63VjONKngDYErvTOIwfADquoeKEtzUAZ9G8FwXHNdgtsVfwwbKQM9oe+YCjKEg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from MN6PR11MB8172.namprd11.prod.outlook.com (2603:10b6:208:478::9) by IA1PR11MB8098.namprd11.prod.outlook.com (2603:10b6:208:44b::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9723.17; Tue, 17 Mar 2026 14:20:22 +0000 Received: from MN6PR11MB8172.namprd11.prod.outlook.com ([fe80::a60e:30b5:37bb:ecfb]) by MN6PR11MB8172.namprd11.prod.outlook.com ([fe80::a60e:30b5:37bb:ecfb%4]) with mapi id 15.20.9723.014; Tue, 17 Mar 2026 14:20:22 +0000 Message-ID: <7247024b-fc8d-4a75-ba15-a10399db03bc@intel.com> Date: Tue, 17 Mar 2026 07:20:18 -0700 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH iwl-net 0/3] idpf: virtchnl locking and async fixes To: Sebastian Andrzej Siewior CC: , , , , , , , , , , , , , , References: <20260316232819.6872-1-emil.s.tantilov@intel.com> <20260317090054.DuPZ6O0O@linutronix.de> Content-Language: en-US From: "Tantilov, Emil S" In-Reply-To: <20260317090054.DuPZ6O0O@linutronix.de> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MW4PR04CA0330.namprd04.prod.outlook.com (2603:10b6:303:82::35) To MN6PR11MB8172.namprd11.prod.outlook.com (2603:10b6:208:478::9) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN6PR11MB8172:EE_|IA1PR11MB8098:EE_ X-MS-Office365-Filtering-Correlation-Id: 2cd8c602-7bcf-4632-ee00-08de8430534a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|7416014|376014|1800799024|56012099003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: QCUMN635W7Q8djmhsSyxRPpaSwLPb/pm16wCg5NoGW+CUrU9eVDio/K+C/UHMmAmPAM1KdCz3WL33kNN3wlS1DvreuRvboSRjwjrFkFHyNAu7Ik44cnAVQWFUNBkZUckNdsBDqtVjg2rzNCpXBfUlq3kuuW0r2K36q5VLsYMNBwwwQ4DhoJfnIKzMrUQh7yeh/79T2YoPHJALuKmuWrY/OjNll2hzUYmbq6u1amnCNrPgNmNVi54cc7XDU6RwowUJee/+gpLNK2TrpsKqLBVtq2dVj74+AXRRlCIiJKEu2Hp2F+AHKazn4ZfA2lLQ2YwbFiyCMzdUOVkwMHSq/pGd/zukSoR24K95/LdZWcG20gWwuFvjZKwBysMPMiS4/5/u2eLumVLmhqu+aqryfy4TE+fNuGZoc2jI1dk6pB3KuYclFI/abSKKAXP2ocfpHMez2iBpi95rys/gtZstP8bSmDhnBgOBn8RS56gwpNH/lc/uTbGUdbE5XqqWge5jiA7BcNAk+Do9d91qvn4QRPWHcfEG7DRKjYThzNmm2EVn0zX7tSxgEwYONpVSoUhrJJiKjM6JIRZN/bNSzSAi71aE7C6YEaQ/0/NBFhvD/xjsvm2cAT7IGEcoTbI2uWaTZOAHOkCRF0lTBGcwM171HOfaVVRyBlrSJTxj3/PH6He469DdOmtlG92iLWVlKedIYrL X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN6PR11MB8172.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(7416014)(376014)(1800799024)(56012099003)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?enArNGVSdFAycmdyQXlUb0hpOWEzcVlHblhDMUN2cXBSTElKM1o5RU9ldDFZ?= =?utf-8?B?WTVpUVhaU1h6UHNCR08wNVdBdS9vNmp2KzNNRXRkNlpoWWNTcG1wYkpxcGwr?= =?utf-8?B?Y2ZGbGtzL2YyRDRGd0tHRlgxbk84ZHN3Y0RiNm51ZHpKTTFxSVlnOFZJSHhW?= =?utf-8?B?c1RPRHhzbG1nNjA4c08xSndLdzNnek1xUlRGZnBCMFpzN0lxeVRJSDBlbGlH?= =?utf-8?B?ZzlqT2ZQcDZvN0d1cDR1UGJwVU5lOWZxSmxYRld3NkZSRUNPTUxBUmVRYms4?= =?utf-8?B?Y2pPb2dFU0lrUzhwekZwMTV1dnYrREJmNXl2YURXYkVaYmJJYTlDWmhVaEhh?= =?utf-8?B?K0NjZlEyelZ1YkM4VWs0cHd5a1VsYU02OWZVTC82SWtNd3B2UVg0WFFzZmo5?= =?utf-8?B?WU12dzl2VEFmd0REOVVIYUlwa1dzL1ZiMVZtQmlVMk5QV0cxU0RUV1hqNWR0?= =?utf-8?B?TU9MM096UytaeEQ3WVIrSlhlNURPSTFxSlFPK253Z2lHOGRFTHVORm1JSVJJ?= =?utf-8?B?TVFVNkN5bUNpZEl5dVpqUGFvdHhsazlCU0ZQdlgxSHFicDUyN3FUVFArNDFs?= =?utf-8?B?ZnArVk1mcmIwampKRElaeGdFZ2lOWjBpMDFIRm51K0ZENkJnVEZZbkc2NlJB?= =?utf-8?B?ejJWRmlOVmcxTFI1bjZBVlROLzJSMnNicFhBOUJNRkUxYzJObEJKMnR0K1dh?= =?utf-8?B?THpuYnhsSDNFdkNzQlk1Und3NlhvakU5ejdMQzdkdU9iSnpuaXFWZ1BDcGpy?= =?utf-8?B?MkYyMStybTVFWWZIeXppSGt6VHI4dEJ0WjhhSGRjNjJWV09SaklvYk5lWmVa?= =?utf-8?B?RzVoQjBmOTdyUVY3bkwwYmd1c1F2dmJpSlJCVXVobCtENEtWOXhTUExuNXlS?= =?utf-8?B?YzhCTUh4TnJ3S09TcWxpRjEvMmFTcUVVeHpxdG5IS0Vyb1lBS0xjZk96VGhV?= =?utf-8?B?N05UTmw1OG5oOHpaUE9PM2hHWi9KN2UvSlJxNXlldmNHT25EaTlLU29kODli?= =?utf-8?B?NTFoaFFwYUFjRlAxYy94S0pjd1NHVXF6dGdmbUdjV2NpTWpEbnFuWWtBMU5n?= =?utf-8?B?UnBYUXV4SG9kdFhBTGZDQkhRRkNEeWxQMm9BL0NDV2p2THZUMGxUZ3N5NUxp?= =?utf-8?B?OUc4WmIwd0lEaHRuYzlhSWF0NG1YVHY2aWZHQUlzajNrdHBXVEJGQ2pnd1lq?= =?utf-8?B?VkN3bkFJTWYzOVB4aDg5SFpOOW1xbitib29rMEtWSmdQL3cxM2ExeXA2bGFO?= =?utf-8?B?WUpaZlZ4elc5OXg0VmdTdkhmTDlJVnNPWlVOQmtQeHZ2NFFrL3YrdWFpamtK?= =?utf-8?B?bDNsdERZays0dlBEaEVSZlE4TGtTcmpwMDlFVGRJcHBmN0dkZjVyTmtIVTUv?= =?utf-8?B?TVZPcGhrRTdsUDQ0L0NNME5wZE1WU0ZUZDlHYy9vVlN2WG9lWU4rcXhPSkJz?= =?utf-8?B?TXhlTzNiajh5d1MybGNhWlMrN0Q5OGFuSGJXZFF2Q0lhclJKeXJDVXZOQkoy?= =?utf-8?B?ejVJWEYxVi92bTZZVVVwTWlhTmoweU5SQjd5cm91c1B1MWg3MEg1TnE3SGV1?= =?utf-8?B?cldhdXhhdEZhbjEyeWpwTTdrUkxoRGJKRXR5Sll1UHFIbnZ3NnhjaDBqQThV?= =?utf-8?B?cm5heUZEdDhhK09aNDFQSm5YaytVMVd5dDY3N1RKRWpPS0VHTk1FOEdrbGQ5?= =?utf-8?B?WUVjdXR5VHdITWIwR3JqcklxUitNdHAxQmZ6eXV3MGt2UktEYzZvbXZRMkpm?= =?utf-8?B?MEs1bm9OOW9aMGh4RGpMTFpIZkZpOS9QTmFxRFRlQ0ZScTlIWFlWVUJtKy9N?= =?utf-8?B?K0xyVnRNZ21EaEZJU3MrMTc4Vk5zbVhmTXozN245dDFtSmNuT2FyVjliSnJU?= =?utf-8?B?YmVlV1QyOWZRSy9CREZVS1NWTE5Hb2NnUW1EREZWN3FQRVJLSHdEeFNNQUlF?= =?utf-8?B?bWJkRWc5UEtIMTNxRml6cEZSbitVaFJvMDY1MjZ5RW5FMGNndUpWU0lEdnU4?= =?utf-8?B?anpKSGMyeS9jbEdUNnNuYVV3QzR4ZVpkeHZDT25FNnVuZFZ4ck9vWndxek1S?= =?utf-8?B?SlJNc0JldmgxKy9xZkxrSXA3NkVhK3NUb21sSlNZSlZzc0ZhRi9nbUtVOGlp?= =?utf-8?B?dXBIY0draENLTytTQ0RWRVp4OEJ6ZUxiN2d2VFFnWDVYY3p4bUxmR2MrRXRF?= =?utf-8?B?V2EzbGx3OEZiT2x6RUVYNm5ManBRYzUyWHdLbTg1RzdhcnpXd2FIUlNHdFpO?= =?utf-8?B?MGxxdStjTE1NN1diZHZrV2RFdEZ0ZUtzcEdnK2lpOWYzVkY1bW5pZ2JPdXBX?= =?utf-8?B?YzU1bUxzQ3Q2L1JFQ0xMYUUzM1BWTjczbCttTjdEaVVMd3dZOG9nK1dBcGdU?= =?utf-8?Q?Mek6VuoQKCLsx0Ss=3D?= X-Exchange-RoutingPolicyChecked: OqZKszglH18uofSpyZKMaVWFZv2igLeUgf0H0qFWREO4Ht2CPqKxU/Dt+qtDEWEAIUXKuiMNHCfDAAhCkcH3L8ZLBNwVG6R3LCvhyv1r4m63TPXPJvrKZ9IZ1D5vlpYOr85RXS66uu1IEmYWrTSjCpHRvaK2LyRLPqkIVK3WUqK2CRrpCkg/7eulBMbBQ/EJKwHHlKGaZ929saD2EDuq6BPrIl/TCqT7bbp4a1AFkOhj8P5O5MzI1y5JReBtI0vHzWuBcFjXxRCgUcyqAMiGLHn4fGTO76iHZBNkq1WnHTv+cjr63TmLlJ4fIUXIPWwAwfbnKM3EBLbWmKNoFlAcSw== X-MS-Exchange-CrossTenant-Network-Message-Id: 2cd8c602-7bcf-4632-ee00-08de8430534a X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8172.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Mar 2026 14:20:22.6027 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Vy8iCAnSlTbGruLZKv3MXJPnrJavdAmqYPmH+WcCtJzeui3OWaEOKAGJmznsBsKf4CIFvxMYXsAmdkQ6fHHD8wYaspB1NwLu0xt1X73fdco= X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB8098 X-OriginatorOrg: intel.com On 3/17/2026 2:00 AM, Sebastian Andrzej Siewior wrote: > On 2026-03-16 16:28:16 [-0700], Emil Tantilov wrote: >> The first patch in this series improves the locking around the setting >> and clearing of the free_xn_bm bitmap. Previously the lock was only >> taken during init shutdown and pop, but not the push function. >> >> Patches 2 and 3 are fixes for the async handler. Patch 2 ensures the >> payload size is set before the async handler is called, and patch 3 fixes >> an sleeping bug due to nesting of raw/bh spinlocks. > > Why is there a raw_spinlock_t? From a quick look a spinlock_t would do > just fine with not runtime change for !PREEMPT_RT. The handling of the virtchannel messages is done via the completion API and the transactions are using the raw spinlock from struct swait_queue_head: https://elixir.bootlin.com/linux/v6.19.8/source/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c#L298 https://git.kernel.org/pub/scm/linux/kernel/git/tnguy/net-queue.git/tree/include/linux/swait.h?h=dev-queue#n44 Thanks, Emil > > Sebastian