From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
To: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>,
Chandrasekar Ramakrishnan <rcsekar@samsung.com>,
Wolfgang Grandegger <wg@grandegger.com>,
Marc Kleine-Budde <mkl@pengutronix.de>
Cc: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
"Felipe Balbi (Intel)" <balbi@kernel.org>,
linux-can@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net 0/4] Fix bit timings for m_can_pci (Elkhart Lake)
Date: Wed, 17 Nov 2021 14:14:27 +0200 [thread overview]
Message-ID: <72489ea7-cf81-2446-3620-06a98f53ce54@linux.intel.com> (raw)
In-Reply-To: <e38eb4ca0a03c60c8bbeccbd8126ffc5bf97d490.camel@ew.tq-group.com>
Hi
On 11/16/21 3:58 PM, Matthias Schiffer wrote:
> I just noticed that m_can_pci is completely broken on 5.15.2, while
> it's working fine on 5.14.y.
>
Hmm.. so that may explain why I once saw candump received just zeroes on
v5.15-rc something but earlier kernels were ok. What's odd then next
time v5.15-rc was ok so went blaming sun spots instead of bisecting.
> I assume something simliar to [1] will be necessary in m_can_pci as
> well, however I'm not really familiar with the driver. There is no
> "mram_base" in m_can_plat_pci, only "base". Is using "base" with
> iowrite32/ioread32 + manual increment the correct solution here?
>
>
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=99d173fbe8944861a00ebd1c73817a1260d21e60
>
If your test case after 5.15 reliably fails are you able to bisect or
check does the regression originate from the same commit?
Jarkko
next prev parent reply other threads:[~2021-11-17 12:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-15 9:18 [PATCH net 0/4] Fix bit timings for m_can_pci (Elkhart Lake) Matthias Schiffer
2021-11-15 9:18 ` [PATCH net 1/4] can: m_can: pci: fix incorrect reference clock rate Matthias Schiffer
2021-11-15 14:48 ` Jarkko Nikula
2021-11-16 7:11 ` Jarkko Nikula
2021-11-16 7:15 ` Marc Kleine-Budde
2021-11-16 14:50 ` Jarkko Nikula
2021-11-15 9:18 ` [PATCH net 2/4] Revert "can: m_can: remove support for custom bit timing" Matthias Schiffer
2021-11-15 9:18 ` [PATCH net 3/4] can: m_can: make custom bittiming fields const Matthias Schiffer
2021-11-15 9:18 ` [PATCH net 4/4] can: m_can: pci: use custom bit timings for Elkhart Lake Matthias Schiffer
2021-11-16 13:58 ` [PATCH net 0/4] Fix bit timings for m_can_pci (Elkhart Lake) Matthias Schiffer
2021-11-17 12:14 ` Jarkko Nikula [this message]
2021-11-18 14:47 ` Matthias Schiffer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=72489ea7-cf81-2446-3620-06a98f53ce54@linux.intel.com \
--to=jarkko.nikula@linux.intel.com \
--cc=balbi@kernel.org \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthias.schiffer@ew.tq-group.com \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=rcsekar@samsung.com \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).