From: Paolo Abeni <pabeni@redhat.com>
To: Anna Emese Nyiri <annaemesenyiri@gmail.com>, netdev@vger.kernel.org
Cc: fejes@inf.elte.hu, edumazet@google.com, kuba@kernel.org,
willemb@google.com, idosch@idosch.org, horms@kernel.org,
davem@davemloft.net, shuah@kernel.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net-next v2] selftests: net: Add support for testing SO_RCVMARK and SO_RCVPRIORITY
Date: Tue, 11 Feb 2025 12:19:24 +0100 [thread overview]
Message-ID: <72634e76-7bb2-48d5-ab21-9d5e86adee9c@redhat.com> (raw)
In-Reply-To: <20250210192216.37756-1-annaemesenyiri@gmail.com>
On 2/10/25 8:22 PM, Anna Emese Nyiri wrote:
> Introduce tests to verify the correct functionality of the SO_RCVMARK and
> SO_RCVPRIORITY socket options.
>
> Key changes include:
>
> - so_rcv_listener.c: Implements a receiver application to test the correct
> behavior of the SO_RCVMARK and SO_RCVPRIORITY options.
> - test_so_rcv.sh: Provides a shell script to automate testing for these options.
> - Makefile: Integrates test_so_rcv.sh into the kernel selftests.
>
> v2:
>
> - Add the C part to TEST_GEN_PROGS and .gitignore.
> - Modify buffer space and add IPv6 testing option
> in so_rcv_listener.c.
> - Add IPv6 testing, remove unnecessary comment,
> add kselftest exit codes, run both binaries in a namespace,
> and add sleep in test_so_rcv.sh.
> The sleep was added to ensure that the listener process has
> enough time to start before the sender attempts to connect.
> - Rebased on net-next.
>
> v1:
>
> https://lore.kernel.org/netdev/20250129143601.16035-2-annaemesenyiri@gmail.com/
Unfortunately the added self-test does not run successfully in the CI:
https://netdev-3.bots.linux.dev/vmksft-net/results/987742/117-so-rcv-listener/stdout
Please have a look at:
https://github.com/linux-netdev/nipa/wiki/How-to-run-netdev-selftests-CI-style
to test the change locally in a CI-like way.
Cheers,
Paolo
next prev parent reply other threads:[~2025-02-11 11:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-10 19:22 [PATCH net-next v2] selftests: net: Add support for testing SO_RCVMARK and SO_RCVPRIORITY Anna Emese Nyiri
2025-02-11 11:19 ` Paolo Abeni [this message]
2025-02-13 12:46 ` Anna Nyiri
2025-02-13 15:06 ` Willem de Bruijn
2025-02-12 1:41 ` Willem de Bruijn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=72634e76-7bb2-48d5-ab21-9d5e86adee9c@redhat.com \
--to=pabeni@redhat.com \
--cc=annaemesenyiri@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fejes@inf.elte.hu \
--cc=horms@kernel.org \
--cc=idosch@idosch.org \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox