Re: [PATCH net-next v7] bonding: Add independent control state machine

[Paolo Abeni <pabeni@redhat.com>]

On Fri, 2024-02-02 at 17:58 +0000, Aahil Awatramani wrote:
> Add support for the independent control state machine per IEEE
> 802.1AX-2008 5.4.15 in addition to the existing implementation of the
> coupled control state machine.
> 
> Introduces two new states, AD_MUX_COLLECTING and AD_MUX_DISTRIBUTING in
> the LACP MUX state machine for separated handling of an initial
> Collecting state before the Collecting and Distributing state. This
> enables a port to be in a state where it can receive incoming packets
> while not still distributing. This is useful for reducing packet loss when
> a port begins distributing before its partner is able to collect.
> 
> Added new functions such as bond_set_slave_tx_disabled_flags and
> bond_set_slave_rx_enabled_flags to precisely manage the port's collecting
> and distributing states. Previously, there was no dedicated method to
> disable TX while keeping RX enabled, which this patch addresses.
> 
> Note that the regular flow process in the kernel's bonding driver remains
> unaffected by this patch. The extension requires explicit opt-in by the
> user (in order to ensure no disruptions for existing setups) via netlink
> support using the new bonding parameter coupled_control. The default value
> for coupled_control is set to 1 so as to preserve existing behaviour.
> 
> Signed-off-by: Aahil Awatramani <aahila@google.com>

A couple of minor nits: you should have retained by acked-by from the
previous revision

> v7:
>   Removed coupled_control from procfs
> v6:
>   Added coupled_control to procfs
> v5:
>   Merge documentation patch with changes patch
>   Add version history in comment description
> v4:
>   Remove inline references from c source files
> v3:
>   Edited commit description
>   Edited documentation description
>   Changed function names
>   Only allow coupled_control change when the bond is down
> v2:
>   Removed sysfs changes
>   Added documentation for new paramater
>   Renamed parameter to coupled_control
>   Update bond_set_slave_inactive_flags() with a 8023ad check

The changelog section should be after a '---' separator, to avoid it
landing into the git history. No need to repost.

Cheers,

Paolo