From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-171.mta0.migadu.com (out-171.mta0.migadu.com [91.218.175.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1FF801EF38C for ; Mon, 10 Mar 2025 23:35:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741649732; cv=none; b=f7Ygq35AQf5jSxM1bBgIZ48XgObXJP93yehTuQwgNjhtD/lAeTLjzMKakwQG78QYpGIr22VuVxjyeMfirYzXdfDORDl1B6Spi2dTWbxXxojFD754gZPO6Eaum+XKMU6f66aXmqo9RvaBFs5nkli9IHwmTS8q/L88sGJwQlzaaTE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741649732; c=relaxed/simple; bh=DPMt326uX8myQJRaJPVu3NPM9NmUtt9Gp/MOi56hFck=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Up3LHznIfs2F6BteFx8+s6A3YXqaf2KF54vYPoI71MW8Kj5QUJWOX07WEwq89Tovlbwbfw5PUVsIVUKyPqPhybWRHZ3qlXZjq8+lfRCMcAMawg96x8/RwKW9NBh1PpOHlKkCMKuhfGntfX5ixK+Hi61qPaXNDndiEHPwiXVzoEw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=fd/x3tMH; arc=none smtp.client-ip=91.218.175.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="fd/x3tMH" Message-ID: <7272e5c8-4205-40fd-a70a-02fa04d52fbe@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1741649717; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1UaeYQ49HJpHXYWhcLyDhDKqa5x+EHwmZ+gZJBiTCA8=; b=fd/x3tMHVeq4mGipakiqpqk9MtleG78tcKb6U3DERxE7ReDb6SwtVFR+vH5T3lfV8oMvsE okBPo8vmhseYKEwdW6jAPvFXMZz9BphO9HHtOxhzOdibRAl4jxQqi28XlYXg3gdMElpgGx U5mXnBlIL+gDX9WNcsCC92vzECxgKsI= Date: Mon, 10 Mar 2025 23:35:11 +0000 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH net 5/5] ptp: ocp: reject unsupported periodic output flags To: Jacob Keller , Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Richard Cochran , Ruud Bos , Paul Barker , =?UTF-8?Q?Niklas_S=C3=B6derlund?= , Bryan Whitehead , UNGLinuxDriver@microchip.com, Raju Lakkaraju , Florian Fainelli , Broadcom internal kernel review list , Andrew Lunn , Heiner Kallweit , Russell King , Jonathan Lemon , Lasse Johnsen Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org References: <20250310-jk-net-fixes-supported-extts-flags-v1-0-854ffb5f3a96@intel.com> <20250310-jk-net-fixes-supported-extts-flags-v1-5-854ffb5f3a96@intel.com> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Vadim Fedorenko In-Reply-To: <20250310-jk-net-fixes-supported-extts-flags-v1-5-854ffb5f3a96@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 10/03/2025 22:16, Jacob Keller wrote: > The ptp_ocp_signal_from_perout() function supports PTP_PEROUT_DUTY_CYCLE > and PTP_PEROUT_PHASE. It does not support PTP_PEROUT_ONE_SHOT, but does not > reject a request with such an unsupported flag. > > Add the appropriate check to ensure that unsupported requests are rejected > both for PTP_PEROUT_ONE_SHOT as well as any future flags. > > Fixes: 1aa66a3a135a ("ptp: ocp: Program the signal generators via PTP_CLK_REQ_PEROUT") > Signed-off-by: Jacob Keller > --- > drivers/ptp/ptp_ocp.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/ptp/ptp_ocp.c b/drivers/ptp/ptp_ocp.c > index b651087f426f50a73229ca57634fc5d6912e0a87..4a87af0980d695a9ab1b23e2544f620759ccb892 100644 > --- a/drivers/ptp/ptp_ocp.c > +++ b/drivers/ptp/ptp_ocp.c > @@ -2090,6 +2090,10 @@ ptp_ocp_signal_from_perout(struct ptp_ocp *bp, int gen, > { > struct ptp_ocp_signal s = { }; > > + if (req->flags & ~(PTP_PEROUT_DUTY_CYCLE | > + PTP_PEROUT_PHASE)) > + return -EOPNOTSUPP; > + > s.polarity = bp->signal[gen].polarity; > s.period = ktime_set(req->period.sec, req->period.nsec); > if (!s.period) > Thanks, Reviewed-by: Vadim Fedorenko