From: Edward Cree <ecree.xilinx@gmail.com>
To: "Íñigo Huguet" <ihuguet@redhat.com>, habetsm.xilinx@gmail.com
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, richardcochran@gmail.com,
netdev@vger.kernel.org, Yalin Li <yalli@redhat.com>
Subject: Re: [PATCH v5 net-next 3/4] sfc: support unicast PTP
Date: Tue, 28 Mar 2023 05:10:19 +0100 [thread overview]
Message-ID: <72849de7-1acc-00e0-5e82-3e62ddcd54fd@gmail.com> (raw)
In-Reply-To: <20230327105755.13949-4-ihuguet@redhat.com>
On 27/03/2023 11:57, Íñigo Huguet wrote:
> When sending a PTP event packet, add the correct filters that will make
> that future incoming unicast PTP event packets will be timestamped.
> The unicast address for the filter is gotten from the outgoing skb
> before sending it.
>
> Until now they were not timestamped because only filters that match with
> the PTP multicast addressed were being configured into the NIC for the
> PTP special channel. Packets received through different channels are not
> timestamped, getting "received SYNC without timestamp" error in ptp4l.
>
> Note that the inserted filters are never removed unless the NIC is stopped
> or reconfigured, so efx_ptp_stop is called. Removal of old filters will
> be handled by the next patch.
>
> Additionally, cleanup a bit efx_ptp_xmit_skb_mc to use the reverse xmas
> tree convention and remove an unnecessary assignment to rc variable in
> void function.
>
> Reported-by: Yalin Li <yalli@redhat.com>
> Signed-off-by: Íñigo Huguet <ihuguet@redhat.com>
> ---
Reviewed-by: Edward Cree <ecree.xilinx@gmail.com>
next prev parent reply other threads:[~2023-03-28 4:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-27 10:57 [PATCH v5 net-next 0/4] sfc: support unicast PTP Íñigo Huguet
2023-03-27 10:57 ` [PATCH v5 net-next 1/4] sfc: store PTP filters in a list Íñigo Huguet
2023-03-28 4:07 ` Edward Cree
2023-03-27 10:57 ` [PATCH v5 net-next 2/4] sfc: allow insertion of filters for unicast PTP Íñigo Huguet
2023-03-28 4:09 ` Edward Cree
2023-03-27 10:57 ` [PATCH v5 net-next 3/4] sfc: support " Íñigo Huguet
2023-03-28 4:10 ` Edward Cree [this message]
2023-03-27 10:57 ` [PATCH v5 net-next 4/4] sfc: remove expired unicast PTP filters Íñigo Huguet
2023-03-28 4:19 ` Edward Cree
2023-03-28 22:47 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=72849de7-1acc-00e0-5e82-3e62ddcd54fd@gmail.com \
--to=ecree.xilinx@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=habetsm.xilinx@gmail.com \
--cc=ihuguet@redhat.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=yalli@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).