From: Paolo Abeni <pabeni@redhat.com>
To: Allison Henderson <achender@kernel.org>, netdev@vger.kernel.org
Cc: linux-kselftest@vger.kernel.org, edumazet@google.com,
rds-devel@oss.oracle.com, kuba@kernel.org, horms@kernel.org,
linux-rdma@vger.kernel.org, shuah@kernel.org,
allison.henderson@oracle.com
Subject: Re: [PATCH net-next v1] selftest: rds: add tools/testing/selftests/net/rds/config
Date: Tue, 17 Mar 2026 15:41:05 +0100 [thread overview]
Message-ID: <728fc0aa-4c07-4092-91bb-6b9f76c2f3eb@redhat.com> (raw)
In-Reply-To: <20260316235848.2395654-1-achender@kernel.org>
On 3/17/26 12:58 AM, Allison Henderson wrote:
> This patch adds an rds selftest config.
Why? what improvement produces or what issues does that address?
> diff --git a/tools/testing/selftests/net/rds/config b/tools/testing/selftests/net/rds/config
> new file mode 100644
> index 000000000000..103f9d941d10
> --- /dev/null
> +++ b/tools/testing/selftests/net/rds/config
> @@ -0,0 +1,5 @@
> +CONFIG_RDS=y
> +CONFIG_RDS_TCP=y
> +CONFIG_NET_NS=y
> +CONFIG_VETH=y
> +CONFIG_NET_SCH_NETEM=y
> diff --git a/tools/testing/selftests/net/rds/config.sh b/tools/testing/selftests/net/rds/config.sh
> index 791c8dbe1095..7cf56ee8882f 100755
> --- a/tools/testing/selftests/net/rds/config.sh
> +++ b/tools/testing/selftests/net/rds/config.sh
> @@ -24,7 +24,7 @@ while getopts "g" opt; do
> esac
> done
>
> -CONF_FILE="tools/testing/selftests/net/config"
> +CONF_FILE="tools/testing/selftests/net/rds/config"
>
> # no modules
> scripts/config --file "$CONF_FILE" --disable CONFIG_MODULES
This looks wrong?!? The script is going to update the config file which
is under git control. You probably want to copy the default config in a
tmp file file, edit the latter and add it to .gitignore and EXTRA_CLEAN.
The issue looks pre-existent, but since you are touching this part...
/P
next prev parent reply other threads:[~2026-03-17 14:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-16 23:58 [PATCH net-next v1] selftest: rds: add tools/testing/selftests/net/rds/config Allison Henderson
2026-03-17 14:41 ` Paolo Abeni [this message]
2026-03-17 18:26 ` Allison Henderson
2026-03-17 21:54 ` Jakub Kicinski
2026-03-18 4:44 ` Allison Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=728fc0aa-4c07-4092-91bb-6b9f76c2f3eb@redhat.com \
--to=pabeni@redhat.com \
--cc=achender@kernel.org \
--cc=allison.henderson@oracle.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rds-devel@oss.oracle.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox