From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A910A3EAC64 for ; Tue, 17 Mar 2026 14:41:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773758472; cv=none; b=VmMhHg2IcTju9Q1OV6eaOLBZITXSJws7T09iFEQYvgC+DAtIBFi0JPqDDc7QN9px6OsOF8LUbQBYAT9hdLKj7pLnNQ7N/H98PuBODJNSPmkeJ6erZ/cOl1AfxABjpXqchqMYavu1qk4BNcff9dtnDLa19WavKH7+CXbmjU5/178= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773758472; c=relaxed/simple; bh=Xec3Bnqs8cOPFzLKCllX85qxRCNRZ4+RoA71Mx5laDg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=fl+bU9vTF5MVBIiFcsBdLycQWvCwasHdW2TKR5tGzAYdwJfbqMqwwPU9WCBVxa05jDqDZtKj3qYrLYN7yI1uJCKd8vO28S1g0ask8FUibayoYaDf0ia7OcLkOLQLprUiw7TKKk+67dkNM5m3GO8oC0uj+WzzRsOEEtbna/F9278= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=cUWH8JN1; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=WG0++1L1; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="cUWH8JN1"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="WG0++1L1" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1773758470; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Oqu0XWMuuVA5H9z7yGNPz2Wm4cgx+SYtal3EMhGWndY=; b=cUWH8JN1rcYk3Mv/vkJl8Ew2rumC7fLlAZbMCs1+CDlfoQZCH0HBUGBByOQe232+6FoaPV /VD6QVGlo4d3pAGzp8UBVCE3Is4WI6wLRM+wp+janFg6R2L8BVGg38GIvzY271AWFFI9ht 0gT0/RfmkPJZbAgWzbg41o7bpO5cYbQ= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-642-whuyqxpsOXSfzP0nrJ6R0A-1; Tue, 17 Mar 2026 10:41:09 -0400 X-MC-Unique: whuyqxpsOXSfzP0nrJ6R0A-1 X-Mimecast-MFC-AGG-ID: whuyqxpsOXSfzP0nrJ6R0A_1773758468 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4853f33b7dbso50936745e9.3 for ; Tue, 17 Mar 2026 07:41:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1773758468; x=1774363268; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Oqu0XWMuuVA5H9z7yGNPz2Wm4cgx+SYtal3EMhGWndY=; b=WG0++1L1eJ+K+WollAoxNY0IvNCOkHl8MTu5IUk2XEXne0hF+bhL0zlZAsloN5//sJ aR8i/KD8c/pbmwNMymLN/pIIjdY9Mg/A5riYsUTRPBnGKQ3N2xqgpQ/iQW/NHBnEuvum MHxRe3kNV2PE47ZV7MU8G4SyRk7DQGmKftWuYRLcVPo6KjhdowfO6HrvZxEq0XL3ZDX0 gbAqDWbbjBkETbeleliXwNVwNe2GERGbDB8IHAAdm2p+aveqSwZ22NzijIsXLY3+e0qE 3VS6j/AdV/Ps08Ztt+zoYMj1wu6GheW9S3Ss3oVU51vA3Fg2G0B93ivEDPq8aGRH6v3Q Ts0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773758468; x=1774363268; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Oqu0XWMuuVA5H9z7yGNPz2Wm4cgx+SYtal3EMhGWndY=; b=D/euNgAvRDURyWIB3rCCDHEopfkNOMCUurQokX0DwsArkr/ETRFeSoYru0GqMsSXuF yqS9GSkiAgL/mr+bNNIsO6d6uzisQcL43BQLMCdD+pGdqXczSrdVZh24DeVkUOBrs7bq sDjXoaFvg6xupbcuqITy31AMpPJg9+/uOW4jAElTbPMGJxWCavO8D0cSNqWPKR+Pm5oJ TbaIR4LYBkhMSBGcKdHIMKaMCivT6W4aKLv6HG2Bh03knMjK5HszlK1AhQU2IA+EP5H4 mp9I9Z9WSni5QVD8OoNOTfvxn5O6UEoMXlHnSvszcXKWkr/GJyOjbnHF3PxX64sRnsiM eyNA== X-Forwarded-Encrypted: i=1; AJvYcCWqkY+eUvs0gX85zK2ZVF5aj6utddMB6RGHVU1cWB/WW86pVe1+NhMrX2GsYyqbHjT+X3mShAw=@vger.kernel.org X-Gm-Message-State: AOJu0YyAf1ZMji9v0IFP1l+yEV6ROJ8rcCMoQfV523NUr2Dik/QdOLpM CUg5Aoj79OIvh0Cg5PugxSAgnmvHUNPGx/KZvoQ1gly2ySc5MgogLWT+qNkS7bx2SFb2qJGOzWr mdKl6yitk3VrDRqXn0MahmNrBa5daDLoy3a9WIhmLH5cL6qIkoDk70rMrJg== X-Gm-Gg: ATEYQzyD/ZdehcVEDg1oI4YWksNk4N3N6wpsveNvUE1p4GFvQPTdha2IZwZdPyjdMbu C/wuITn8aUhAD4ui2Ykd62XWE11lvnCAm3atXXzHx+308bIcXmfhT32ne8SM9S132m94lhJc60N FSzbkek+2P22HYKBYtLRVBLR/hi911Ml1wrFQMV1AfijE7JbDwypb7NvUxIPcezHx5eNuwMcybB +/ecmhoBPdTCHm8CokTT0U5F+04ElkY6sG78xMvaeXxU6mCpVU3zsdv9C9z0EhB/nJo4vyj4pgl kcfJwMUKerXQAss1lPfIe4fsHw2P4/iN3jxAqXn35lCy61zCLQuyOD4NSJdgz3KqkLCgJtJSZaD kBWVhW4tl2Bg1MYdT5OnGbmqexuzdSfKChcb14u5Hd14B5nYtSXzh1Nc= X-Received: by 2002:a05:600c:35cd:b0:485:ae14:8191 with SMTP id 5b1f17b1804b1-485ae14864fmr48934265e9.5.1773758467695; Tue, 17 Mar 2026 07:41:07 -0700 (PDT) X-Received: by 2002:a05:600c:35cd:b0:485:ae14:8191 with SMTP id 5b1f17b1804b1-485ae14864fmr48933695e9.5.1773758467265; Tue, 17 Mar 2026 07:41:07 -0700 (PDT) Received: from [192.168.88.32] ([216.128.11.95]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439fe2186e3sm57258205f8f.26.2026.03.17.07.41.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Mar 2026 07:41:06 -0700 (PDT) Message-ID: <728fc0aa-4c07-4092-91bb-6b9f76c2f3eb@redhat.com> Date: Tue, 17 Mar 2026 15:41:05 +0100 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v1] selftest: rds: add tools/testing/selftests/net/rds/config To: Allison Henderson , netdev@vger.kernel.org Cc: linux-kselftest@vger.kernel.org, edumazet@google.com, rds-devel@oss.oracle.com, kuba@kernel.org, horms@kernel.org, linux-rdma@vger.kernel.org, shuah@kernel.org, allison.henderson@oracle.com References: <20260316235848.2395654-1-achender@kernel.org> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20260316235848.2395654-1-achender@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/17/26 12:58 AM, Allison Henderson wrote: > This patch adds an rds selftest config. Why? what improvement produces or what issues does that address? > diff --git a/tools/testing/selftests/net/rds/config b/tools/testing/selftests/net/rds/config > new file mode 100644 > index 000000000000..103f9d941d10 > --- /dev/null > +++ b/tools/testing/selftests/net/rds/config > @@ -0,0 +1,5 @@ > +CONFIG_RDS=y > +CONFIG_RDS_TCP=y > +CONFIG_NET_NS=y > +CONFIG_VETH=y > +CONFIG_NET_SCH_NETEM=y > diff --git a/tools/testing/selftests/net/rds/config.sh b/tools/testing/selftests/net/rds/config.sh > index 791c8dbe1095..7cf56ee8882f 100755 > --- a/tools/testing/selftests/net/rds/config.sh > +++ b/tools/testing/selftests/net/rds/config.sh > @@ -24,7 +24,7 @@ while getopts "g" opt; do > esac > done > > -CONF_FILE="tools/testing/selftests/net/config" > +CONF_FILE="tools/testing/selftests/net/rds/config" > > # no modules > scripts/config --file "$CONF_FILE" --disable CONFIG_MODULES This looks wrong?!? The script is going to update the config file which is under git control. You probably want to copy the default config in a tmp file file, edit the latter and add it to .gitignore and EXTRA_CLEAN. The issue looks pre-existent, but since you are touching this part... /P