From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE611C31E40 for ; Fri, 9 Aug 2019 08:52:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9B6F620B7C for ; Fri, 9 Aug 2019 08:52:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405977AbfHIIwc (ORCPT ); Fri, 9 Aug 2019 04:52:32 -0400 Received: from mail02.iobjects.de ([188.40.134.68]:54734 "EHLO mail02.iobjects.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2405941AbfHIIwc (ORCPT ); Fri, 9 Aug 2019 04:52:32 -0400 Received: from tux.wizards.de (p5DE2B30B.dip0.t-ipconnect.de [93.226.179.11]) by mail02.iobjects.de (Postfix) with ESMTPSA id 9F5EA416013A; Fri, 9 Aug 2019 10:52:30 +0200 (CEST) Received: from [192.168.100.223] (ragnarok.applied-asynchrony.com [192.168.100.223]) by tux.wizards.de (Postfix) with ESMTP id 6CB0FF0160E; Fri, 9 Aug 2019 10:52:30 +0200 (CEST) Subject: Re: [PATCH net-next] r8169: make use of xmit_more To: Eric Dumazet Cc: Heiner Kallweit , Realtek linux nic maintainers , David Miller , "netdev@vger.kernel.org" , Sander Eikelenboom References: <2950b2f7-7460-cce0-d964-ad654d897295@gmail.com> <868a1f4c-5fba-c64b-ea31-30a3770e6a2f@applied-asynchrony.com> From: =?UTF-8?Q?Holger_Hoffst=c3=a4tte?= Organization: Applied Asynchrony, Inc. Message-ID: <72a58a6b-974c-0feb-2fa4-c8a71c7eff7e@applied-asynchrony.com> Date: Fri, 9 Aug 2019 10:52:30 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 8/9/19 10:25 AM, Eric Dumazet wrote: (snip) >> >> So that didn't take long - got another timeout this morning during some >> random light usage, despite sg/tso being disabled this time. >> Again the only common element is the xmit_more patch. :( >> Not sure whether you want to revert this right away or wait for 5.4-rc1 >> feedback. Maybe this too is chipset-specific? >> >>> Thanks a lot for the analysis and testing. Then I'll submit the disabling >>> of SG on RTL8168evl (on your behalf), independent of whether it fixes >>> the timeout issue. >> >> Got it, thanks! >> >> Holger > > I would try this fix maybe ? > > diff --git a/drivers/net/ethernet/realtek/r8169_main.c > b/drivers/net/ethernet/realtek/r8169_main.c > index b2a275d8504cf099cff738f2f7554efa9658fe32..e77628813daba493ad50dab9ac1e3703e38b560c > 100644 > --- a/drivers/net/ethernet/realtek/r8169_main.c > +++ b/drivers/net/ethernet/realtek/r8169_main.c > @@ -5691,6 +5691,7 @@ static netdev_tx_t rtl8169_start_xmit(struct sk_buff *skb, > */ > smp_wmb(); > netif_stop_queue(dev); > + door_bell = true; > } > > if (door_bell) > Thanks Eric, I'll give that a try and see how it fares over the next few days. It suspiciously looks like it could help.. -h