From: "Qingshuang Fu" <fuqingshuang@kylinos.cn>
To: "Hangbin Liu" <liuhangbin@gmail.com>
Cc: "Pablo Neira Ayuso" <pablo@netfilter.org>,
"Florian Westphal" <fw@strlen.de>,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Fernando Fernandez Mancera" <fmancera@suse.de>
Subject: Re: [PATCH net v2] selftests: netfilter: conntrack_dump_flush: remove unused variables and fix typo
Date: Mon, 10 Aug 2026 11:01:09 +0800 (CST) [thread overview]
Message-ID: <72b995d7.271c.19fe99ded3b.Coremail.fuqingshuang@kylinos.cn> (raw)
In-Reply-To: <anbMGS9TFOEUUWu-@fedora>
At 2026-08-08 14:26:33, "Hangbin Liu" <liuhangbin@gmail.com> wrote:
>On Fri, Aug 07, 2026 at 12:23:45PM +0200, Pablo Neira Ayuso wrote:
>> On Fri, Aug 07, 2026 at 05:07:13PM +0800, Hangbin Liu wrote:
>> > On Fri, Aug 07, 2026 at 03:59:28PM +0800, Qingshuang Fu wrote:
>> > > From: Qingshuang Fu <fuqingshuang@kylinos.cn>
>> > >
>> > > Remove unused 'rplnlh' in conntrack_data_insert(), and remove unused
>> > > 'rplnlh' and 'nest' variables in conntrack_count_zone() and
>> > > conntrack_flush_zone(). These variables were declared but never used
>> > > since their introduction.
>> > >
>> > > Also fix typo: rename misspelled conntracK_count_zone() to
>> > > conntrack_count_zone().
>> > >
>> > > Reviewed-by: Fernando Fernandez Mancera <fmancera@suse.de>
>> > > Signed-off-by: Qingshuang Fu <fuqingshuang@kylinos.cn>
>> >
>> > > ---
>> > > v2:
>> > > - Drop Fixes tag as this is a cleanup, not a bug fix
>> >
>> > If not a bug fix, you should target to net-next.
>>
>> We will handle this though the nf-next tree.
>
>Oh, good. That's more reasonable.
>
Thanks all for the review and clarification.
Best regards,
Qingshuang Fu
prev parent reply other threads:[~2026-08-10 3:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-07 7:59 [PATCH net v2] selftests: netfilter: conntrack_dump_flush: remove unused variables and fix typo Qingshuang Fu
2026-08-07 9:07 ` Hangbin Liu
2026-08-07 10:23 ` Pablo Neira Ayuso
2026-08-08 6:26 ` Hangbin Liu
2026-08-10 3:01 ` Qingshuang Fu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=72b995d7.271c.19fe99ded3b.Coremail.fuqingshuang@kylinos.cn \
--to=fuqingshuang@kylinos.cn \
--cc=coreteam@netfilter.org \
--cc=fmancera@suse.de \
--cc=fw@strlen.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox