From: Jacob Keller <jacob.e.keller@intel.com>
To: Patrick Thompson <ptf@google.com>, <netdev@vger.kernel.org>
Cc: Chun-Hao Lin <hau@realtek.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
<linux-kernel@vger.kernel.org>, <nic_swsd@realtek.com>
Subject: Re: [PATCH v3] net: r8169: Disable multicast filter for RTL8168H and RTL8107E
Date: Mon, 30 Oct 2023 14:44:39 -0700 [thread overview]
Message-ID: <72d0fdeb-b08b-45f2-8a24-d20db69c4a02@intel.com> (raw)
In-Reply-To: <20231030205031.177855-1-ptf@google.com>
On 10/30/2023 1:50 PM, Patrick Thompson wrote:
> RTL8168H and RTL8107E ethernet adapters erroneously filter unicast
> eapol packets unless allmulti is enabled. These devices correspond to
> RTL_GIGA_MAC_VER_46 and VER_48. Add an exception for VER_46 and VER_48
> in the same way that VER_35 has an exception.
>
> Fixes: 6e1d0b898818 ("r8169:add support for RTL8168H and RTL8107E")
> Signed-off-by: Patrick Thompson <ptf@google.com>
> ---
>
> Changes in v3:
> - disable mc filter for VER_48
> - update description
>
> Changes in v2:
> - add Fixes tag
> - add net annotation
> - update description
>
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
next prev parent reply other threads:[~2023-10-30 21:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-30 20:50 [PATCH v3] net: r8169: Disable multicast filter for RTL8168H and RTL8107E Patrick Thompson
2023-10-30 21:44 ` Jacob Keller [this message]
2023-10-30 22:02 ` Heiner Kallweit
2023-11-02 12:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=72d0fdeb-b08b-45f2-8a24-d20db69c4a02@intel.com \
--to=jacob.e.keller@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hau@realtek.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=pabeni@redhat.com \
--cc=ptf@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).