netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hayes Wang <hayeswang@realtek.com>
To: Douglas Anderson <dianders@chromium.org>,
	Jakub Kicinski <kuba@kernel.org>,
	"David S . Miller" <davem@davemloft.net>
Cc: "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"Grant Grundler" <grundler@chromium.org>,
	"Laura Nao" <laura.nao@collabora.com>,
	"Edward Hill" <ecgh@chromium.org>,
	"Alan Stern" <stern@rowland.harvard.edu>,
	"Simon Horman" <horms@kernel.org>, "Bjørn Mork" <bjorn@mork.no>,
	"Eric Dumazet" <edumazet@google.com>,
	"Paolo Abeni" <pabeni@redhat.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: RE: [PATCH net v3 2/5] r8152: Add RTL8152_INACCESSIBLE checks to more loops
Date: Thu, 30 Nov 2023 08:27:00 +0000	[thread overview]
Message-ID: <72e1773d60c94a43ba9d97fa89a8dd1c@realtek.com> (raw)
In-Reply-To: <20231129132521.net.v3.2.I79c8a6c8cafd89979af5407d77a6eda589833dca@changeid>

Douglas Anderson <dianders@chromium.org>
[...]
> 
> Previous commits added checks for RTL8152_INACCESSIBLE in the loops in
> the driver. There are still a few more that keep tripping the driver
> up in error cases and make things take longer than they should. Add
> those in.
> 
> All the loops that are part of this commit existed in some form or
> another since the r8152 driver was first introduced, though
> RTL8152_INACCESSIBLE was known as RTL8152_UNPLUG before commit
> 715f67f33af4 ("r8152: Rename RTL8152_UNPLUG to RTL8152_INACCESSIBLE")
> 
> Fixes: ac718b69301c ("net/usb: new driver for RTL8152")
> Reviewed-by: Grant Grundler <grundler@chromium.org>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>

Acked-by: Hayes Wang <hayeswang@realtek.com>

Best Regards,
Hayes


  reply	other threads:[~2023-11-30  8:27 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-29 21:25 [PATCH net v3 1/5] r8152: Hold the rtnl_lock for all of reset Douglas Anderson
2023-11-29 21:25 ` [PATCH net v3 2/5] r8152: Add RTL8152_INACCESSIBLE checks to more loops Douglas Anderson
2023-11-30  8:27   ` Hayes Wang [this message]
2023-11-29 21:25 ` [PATCH net v3 3/5] r8152: Add RTL8152_INACCESSIBLE to r8156b_wait_loading_flash() Douglas Anderson
2023-11-30  8:27   ` Hayes Wang
2023-11-29 21:25 ` [PATCH net v3 4/5] r8152: Add RTL8152_INACCESSIBLE to r8153_pre_firmware_1() Douglas Anderson
2023-11-30  8:27   ` Hayes Wang
2023-11-29 21:25 ` [PATCH net v3 5/5] r8152: Add RTL8152_INACCESSIBLE to r8153_aldps_en() Douglas Anderson
2023-11-30  8:27   ` Hayes Wang
2023-12-04 12:30 ` [PATCH net v3 1/5] r8152: Hold the rtnl_lock for all of reset patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=72e1773d60c94a43ba9d97fa89a8dd1c@realtek.com \
    --to=hayeswang@realtek.com \
    --cc=bjorn@mork.no \
    --cc=davem@davemloft.net \
    --cc=dianders@chromium.org \
    --cc=ecgh@chromium.org \
    --cc=edumazet@google.com \
    --cc=grundler@chromium.org \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=laura.nao@collabora.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).