From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F88AC43381 for ; Sun, 17 Feb 2019 18:39:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F1B4D2186A for ; Sun, 17 Feb 2019 18:39:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MUHyCoqr" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726144AbfBQSjO (ORCPT ); Sun, 17 Feb 2019 13:39:14 -0500 Received: from mail-yw1-f54.google.com ([209.85.161.54]:45174 "EHLO mail-yw1-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725554AbfBQSjO (ORCPT ); Sun, 17 Feb 2019 13:39:14 -0500 Received: by mail-yw1-f54.google.com with SMTP id d190so5622093ywd.12 for ; Sun, 17 Feb 2019 10:39:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=d8DtZ7fo+qyh2mhBdHPvMg4F27fHmfip9QndbCjO/1w=; b=MUHyCoqrxfVYIk1ea3IS/WFJ2+TKyECqTGlh1UsWGI0ZL6CZXyS9mF9AOsaP7YgzA4 P8N0RsI8+QbvfZPI+SuwXg/Lz7TGn+QE2M6T5kjVWtZUoOzJ0+oXHJwPkRgT2he9kOxD aQxGHJ7EzTeBzXoDivGDTbj7So+uHvrH0DTbqC1eEhYZHAYPIscLFwGCt0r9UTX15BjE O4Ne7HOw5ZUHzotZ2n2y2UbTzy5LJn3rm15VuaRe2/wV3zAjLqJd8H+PpXt5mHzrOZvw /rASWjKHSlOB6KA5r2BT8e5EPxOcYRkpy+pN612/Gb8cNn3LMVrNERF6FO5b11MAJwE7 594Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=d8DtZ7fo+qyh2mhBdHPvMg4F27fHmfip9QndbCjO/1w=; b=QvArX+fQRSmivMkOKM/QN11YwzwEURyqWooPGCMyUcoRUW8F/G5S43EmzGssNyMCZO 3+KW2frCbZ2GHTOYwMutbbUUA9YCXc50E7wdmehFpZ2qFT8K3RGbAGzsjta1efKiB2/b cZZrmaxSmDu/1VDbg3ta9lxz0UO/A4EYXIQLhh5W085UGeNwZ7ZngR/pIxqcRnAn9G8O pbykSK2DJMpNKjuskp31Ooy9ogjdXKwaLUrIko3ZjL/JAICxR3XuosbCJnYFjd8XEa5R pGkFww2QEuhFXf5g5hwjqKuMPTQNHIpaDavlHLIA0GrFzOW7K+r6+/RiOVW1olE6iopb PqRQ== X-Gm-Message-State: AHQUAubI+Q1/pqQqTNiJtIcrQADJKv/YJrX52fg7oJO/VmljUaWfNwM9 3xLoIwW99w3D4CvhdPXd+ldPm2rQ X-Google-Smtp-Source: AHgI3IYcsrFgONVicMN2zWrCcqF5jEhnFarPLtJU+PR/GLof0WZBSTz/iJ0wdD90jatmeeLulD70Sw== X-Received: by 2002:a0d:e703:: with SMTP id q3mr5246813ywe.382.1550428752998; Sun, 17 Feb 2019 10:39:12 -0800 (PST) Received: from [192.168.86.235] (c-73-241-150-70.hsd1.ca.comcast.net. [73.241.150.70]) by smtp.gmail.com with ESMTPSA id b7sm4015734ywa.86.2019.02.17.10.39.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 17 Feb 2019 10:39:11 -0800 (PST) Subject: Re: ax25: fix possible use-after-free To: f6bvp , netdev@vger.kernel.org References: <20190216233349.7977096b@draws-f6bvp> From: Eric Dumazet Message-ID: <73130cb1-4fe8-6079-4e9b-678cb34de9b2@gmail.com> Date: Sun, 17 Feb 2019 10:39:08 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190216233349.7977096b@draws-f6bvp> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 02/16/2019 02:33 PM, f6bvp wrote: > > Patch applied successfully on Linux draws-f6bvp 4.14.79-v7+ #1159 SMP Sun Nov 4 17:50:20 GMT 2018 armv7l GNU/Linux > > However ax25_route_lock_use and ax25_route_lock_unuse() are not declared and compile failed. > > make : on entre dans le répertoire « /usr/src/linux-headers-4.14.79-v7+ » > CC [M] /usr/src/linux-4.14.y/net/ax25/ax25_ip.o > /usr/src/linux-4.14.y/net/ax25/ax25_ip.c: In function ‘ax25_ip_xmit’: > /usr/src/linux-4.14.y/net/ax25/ax25_ip.c:117:2: error: implicit declaration of function ‘ax25_route_lock_use’ [-Werror=implicit-function-declaration] > ax25_route_lock_use(); > ^~~~~~~~~~~~~~~~~~~ > /usr/src/linux-4.14.y/net/ax25/ax25_ip.c:211:2: error: implicit declaration of function ‘ax25_route_lock_unuse’ [-Werror=implicit-function-declaration] > ax25_route_lock_unuse(); > ^~~~~~~~~~~~~~~~~~~~~ > cc1: some warnings being treated as errors > scripts/Makefile.build:328 : la recette pour la cible « /usr/src/linux-4.14.y/net/ax25/ax25_ip.o » a echouee > make[1]: *** [/usr/src/linux-4.14.y/net/ax25/ax25_ip.o] Erreur 1 > Makefile:1527 : la recette pour la cible « _module_/usr/src/linux-4.14.y/net/ax25 » a echouee > make: *** [_module_/usr/src/linux-4.14.y/net/ax25] Erreur 2 > make : on quitte le repertoire « /usr/src/linux-headers-4.14.79-v7+ » > > > Bernard, f6bvp > Hi Bernard Are you sure you applied the patch correctly/completely ? git cherry-pick worked without conflicts on top of 4.14.100