Netdev List
 help / color / mirror / Atom feed
From: Yonghong Song <yhs@fb.com>
To: Andrii Nakryiko <andriin@fb.com>,
	"bpf@vger.kernel.org" <bpf@vger.kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	Alexei Starovoitov <ast@fb.com>,
	"daniel@iogearbox.net" <daniel@iogearbox.net>
Cc: "andrii.nakryiko@gmail.com" <andrii.nakryiko@gmail.com>,
	Kernel Team <Kernel-team@fb.com>
Subject: Re: [PATCH bpf-next] selftests/bpf: enforce no-ALU32 for test_progs-no_alu32
Date: Wed, 20 Nov 2019 00:32:17 +0000	[thread overview]
Message-ID: <7317c35c-d8f2-25d4-d40d-6d27b99a1c6e@fb.com> (raw)
In-Reply-To: <20191120002510.4130605-1-andriin@fb.com>



On 11/19/19 4:25 PM, Andrii Nakryiko wrote:
> With the most recent Clang, alu32 is enabled by default if -mcpu=probe or
> -mcpu=v3 is specified. Use a separate build rule with -mcpu=v2 to enforce no

A little bit clarification -mcpu=probe may not enable alu32 for old 
kernels. alu32 enabled with -mcpu=probe only if kernel supports jmp32, 
which is merged in January this year.

> ALU32 mode.
> 
> Suggested-by: Yonghong Song <yhs@fb.com>
> Signed-off-by: Andrii Nakryiko <andriin@fb.com>

With the above nit,
Acked-by: Yonghong Song <yhs@fb.com>

  reply	other threads:[~2019-11-20  0:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-20  0:25 [PATCH bpf-next] selftests/bpf: enforce no-ALU32 for test_progs-no_alu32 Andrii Nakryiko
2019-11-20  0:32 ` Yonghong Song [this message]
2019-11-20  0:55   ` Alexei Starovoitov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7317c35c-d8f2-25d4-d40d-6d27b99a1c6e@fb.com \
    --to=yhs@fb.com \
    --cc=Kernel-team@fb.com \
    --cc=andrii.nakryiko@gmail.com \
    --cc=andriin@fb.com \
    --cc=ast@fb.com \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox