netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net 1/3] virtio-net: drop the rest of buffers when we can't allocate skb
@ 2013-11-20  9:07 Jason Wang
  2013-11-20  9:07 ` [PATCH net 2/3] virtio-net: fix num calculation on frag skb allocation failure Jason Wang
                   ` (3 more replies)
  0 siblings, 4 replies; 14+ messages in thread
From: Jason Wang @ 2013-11-20  9:07 UTC (permalink / raw)
  To: rusty, mst, virtualization, netdev, linux-kernel
  Cc: Michael Dalton, Eric Dumazet, Shirley Ma

When mergeable buffer were used, we only put the first page buf leave the rest
of buffers in the virt queue. This will cause the driver could not get the
correct head buffer any more. Fix this by dropping the rest of buffers for this
packet.

The bug was introduced by commit 9ab86bbcf8be755256f0a5e994e0b38af6b4d399
(virtio_net: Defer skb allocation in receive path).

Cc: Rusty Russell <rusty@rustcorp.com.au>
Cc: Michael S. Tsirkin <mst@redhat.com>
Cc: Michael Dalton <mwdalton@google.com>
Cc: Eric Dumazet <edumazet@google.com>
Cc: Shirley Ma <xma@us.ibm.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
---
This patch was needed for stable
---
 drivers/net/virtio_net.c | 18 +++++++++++++++++-
 1 file changed, 17 insertions(+), 1 deletion(-)

diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index 7bab4de..24fd502 100644
--- a/drivers/net/virtio_net.c
+++ b/drivers/net/virtio_net.c
@@ -222,6 +222,17 @@ static void skb_xmit_done(struct virtqueue *vq)
 	netif_wake_subqueue(vi->dev, vq2txq(vq));
 }
 
+static void drop_mergeable_buffer(struct receive_queue *rq, int num_buf)
+{
+	char *buf;
+	int len;
+
+	while (--num_buf && (buf = virtqueue_get_buf(rq->vq, &len)) != NULL) {
+		--rq->num;
+		put_page(virt_to_head_page(buf));
+	}
+}
+
 /* Called from bottom half context */
 static struct sk_buff *page_to_skb(struct receive_queue *rq,
 				   struct page *page, unsigned int offset,
@@ -237,8 +248,13 @@ static struct sk_buff *page_to_skb(struct receive_queue *rq,
 
 	/* copy small packet so we can reuse these pages for small data */
 	skb = netdev_alloc_skb_ip_align(vi->dev, GOOD_COPY_LEN);
-	if (unlikely(!skb))
+	if (unlikely(!skb)) {
+		if (vi->mergeable_rx_bufs) {
+			hdr = (struct skb_vnet_hdr *)p;
+			drop_mergeable_buffer(rq, hdr->mhdr.num_buffers);
+		}
 		return NULL;
+	}
 
 	hdr = skb_vnet_hdr(skb);
 
-- 
1.8.3.2

^ permalink raw reply related	[flat|nested] 14+ messages in thread
end of thread, other threads:[~2013-11-21  3:27 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-20  9:07 [PATCH net 1/3] virtio-net: drop the rest of buffers when we can't allocate skb Jason Wang
2013-11-20  9:07 ` [PATCH net 2/3] virtio-net: fix num calculation on frag skb allocation failure Jason Wang
2013-11-20 10:37   ` Michael S. Tsirkin
2013-11-20 12:08     ` Jason Wang
2013-11-20 13:37       ` Michael S. Tsirkin
2013-11-20 13:56         ` Jason Wang
2013-11-20  9:07 ` [PATCH net 3/3] virtio-net: fix resources leaking when fail to allocate frag skb Jason Wang
2013-11-20 10:34 ` [PATCH net 1/3] virtio-net: drop the rest of buffers when we can't allocate skb Michael S. Tsirkin
2013-11-20 12:08   ` Jason Wang
2013-11-20 13:27     ` Michael S. Tsirkin
2013-11-20 13:26 ` [PATCH RFC] virtio_net: fix error handling for mergeable buffers Michael S. Tsirkin
2013-11-20 13:54   ` Jason Wang
2013-11-20 14:20     ` Michael S. Tsirkin
2013-11-21  3:27       ` Jason Wang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).