From: <Parthiban.Veerasooran@microchip.com>
To: <bastien.curutchet@bootlin.com>, <Woojung.Huh@microchip.com>,
<UNGLinuxDriver@microchip.com>, <andrew@lunn.ch>,
<olteanv@gmail.com>, <davem@davemloft.net>, <edumazet@google.com>,
<kuba@kernel.org>, <pabeni@redhat.com>, <robh@kernel.org>,
<krzk+dt@kernel.org>, <conor+dt@kernel.org>, <marex@denx.de>
Cc: <thomas.petazzoni@bootlin.com>, <miquel.raynal@bootlin.com>,
<pascal.eberhard@se.com>, <netdev@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next 2/2] net: dsa: microchip: configure strap pins during reset
Date: Thu, 11 Sep 2025 10:53:41 +0000 [thread overview]
Message-ID: <7361bf07-892b-406f-aca5-c53a7d876ac4@microchip.com> (raw)
In-Reply-To: <20250910-ksz-strap-pins-v1-2-6308bb2e139e@bootlin.com>
Hi,
On 10/09/25 8:25 pm, Bastien Curutchet wrote:
> diff --git a/drivers/net/dsa/microchip/ksz_common.c b/drivers/net/dsa/microchip/ksz_common.c
> index 7292bfe2f7cac3a0d88bb51339cc287f56ca1d1f..0ab201a3c336b99ba92d87c003ba48f7f82a098a 100644
> --- a/drivers/net/dsa/microchip/ksz_common.c
> +++ b/drivers/net/dsa/microchip/ksz_common.c
> @@ -23,6 +23,7 @@
> #include <linux/of_mdio.h>
> #include <linux/of_net.h>
> #include <linux/micrel_phy.h>
> +#include <linux/pinctrl/consumer.h>
> #include <net/dsa.h>
> #include <net/ieee8021q.h>
> #include <net/pkt_cls.h>
> @@ -5338,6 +5339,44 @@ static int ksz_parse_drive_strength(struct ksz_device *dev)
> return 0;
> }
>
> +static int ksz_configure_strap(struct ksz_device *dev)
> +{
> + struct pinctrl_state *state = NULL;
I don't think you need to initialize here.
> + struct pinctrl *pinctrl;
> + int ret;
> +
Best regards,
Parthiban V
next prev parent reply other threads:[~2025-09-11 10:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-10 14:55 [PATCH net-next 0/2] net: dsa: microchip: Add strap configuration during reset Bastien Curutchet
2025-09-10 14:55 ` [PATCH net-next 1/2] dt-bindings: net: dsa: microchip: Add strap description Bastien Curutchet
2025-09-10 14:55 ` [PATCH net-next 2/2] net: dsa: microchip: configure strap pins during reset Bastien Curutchet
2025-09-10 15:38 ` Miquel Raynal
2025-09-11 11:22 ` Bastien Curutchet
2025-09-10 16:46 ` Andrew Lunn
2025-09-11 8:04 ` Bastien Curutchet
2025-09-11 10:53 ` Parthiban.Veerasooran [this message]
2025-09-10 16:27 ` [PATCH net-next 0/2] net: dsa: microchip: Add strap configuration " Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7361bf07-892b-406f-aca5-c53a7d876ac4@microchip.com \
--to=parthiban.veerasooran@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=Woojung.Huh@microchip.com \
--cc=andrew@lunn.ch \
--cc=bastien.curutchet@bootlin.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
--cc=miquel.raynal@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=pascal.eberhard@se.com \
--cc=robh@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).