From: Florian Fainelli <f.fainelli@gmail.com>
To: Hauke Mehrtens <hauke@hauke-m.de>
Cc: davem@davemloft.net, zambrano@broadcom.com, netdev@vger.kernel.org
Subject: Re: [PATCH 0/8] b44: add support for external PHY
Date: Sun, 15 Dec 2013 21:26:51 +0000 [thread overview]
Message-ID: <7394379.FK49e23POm@lenovo> (raw)
In-Reply-To: <1387132925-18651-1-git-send-email-hauke@hauke-m.de>
Hello Hauke,
Le dimanche 15 décembre 2013, 19:41:57 Hauke Mehrtens a écrit :
> This adds support for an external phy connected to the mac controlled
> by b44. This is used on home routers of the BCM47xx line where this MAC
> core was used and is contended to an external switch core through MII.
> These patches are in OpenWrt for some time and are tested by different
> users with different devices.
Besides my comment on patch 8, this series looks fine to me, thanks!
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
>
> Hauke Mehrtens (8):
> b44: cheek register instead of PHY address to detect external PHY
> b44: rename B44_PHY_ADDR_NO_PHY to B44_PHY_ADDR_NO_LOCAL_PHY
> b44: abort when no PHY is available at all
> b44: rename b44_mii_{read,write} to b44_mdio_{read,write}_mii
> b44: add phylib support
> b44: activate PHY when MAC is off
> b44: do not set PHY address to 30 for every ext PHY
> b44: add dummy PHY device if we do not find any
>
> drivers/net/ethernet/broadcom/Kconfig | 1 +
> drivers/net/ethernet/broadcom/b44.c | 254
> ++++++++++++++++++++++++++++++--- drivers/net/ethernet/broadcom/b44.h |
> 15 +-
> 3 files changed, 244 insertions(+), 26 deletions(-)
--
Florian
prev parent reply other threads:[~2013-12-15 21:26 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-15 18:41 [PATCH 0/8] b44: add support for external PHY Hauke Mehrtens
2013-12-15 18:41 ` [PATCH 1/8] b44: cheek register instead of PHY address to detect " Hauke Mehrtens
2013-12-15 20:04 ` Sergei Shtylyov
2013-12-15 18:41 ` [PATCH 2/8] b44: rename B44_PHY_ADDR_NO_PHY to B44_PHY_ADDR_NO_LOCAL_PHY Hauke Mehrtens
2013-12-16 15:51 ` Ben Hutchings
2013-12-16 18:40 ` Florian Fainelli
2013-12-19 1:21 ` Hauke Mehrtens
2013-12-15 18:42 ` [PATCH 3/8] b44: abort when no PHY is available at all Hauke Mehrtens
2013-12-15 18:42 ` [PATCH 4/8] b44: rename b44_mii_{read,write} to b44_mdio_{read,write}_mii Hauke Mehrtens
2013-12-15 18:42 ` [PATCH 5/8] b44: add phylib support Hauke Mehrtens
2013-12-15 18:42 ` [PATCH 6/8] b44: activate PHY when MAC is off Hauke Mehrtens
2013-12-15 18:42 ` [PATCH 7/8] b44: do not set PHY address to 30 for every ext PHY Hauke Mehrtens
2013-12-15 18:42 ` [PATCH 8/8] b44: add dummy PHY device if we do not find any Hauke Mehrtens
2013-12-15 21:26 ` Florian Fainelli
2013-12-15 23:31 ` Hauke Mehrtens
2013-12-16 3:42 ` Florian Fainelli
2013-12-15 21:26 ` Florian Fainelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7394379.FK49e23POm@lenovo \
--to=f.fainelli@gmail.com \
--cc=davem@davemloft.net \
--cc=hauke@hauke-m.de \
--cc=netdev@vger.kernel.org \
--cc=zambrano@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).