From: David Ahern <dsahern@kernel.org>
To: kuba@kernel.org, davem@davemloft.net, pabeni@redhat.com
Cc: netdev@vger.kernel.org, idosch@idosch.org,
Gwangun Jung <exsociety@gmail.com>
Subject: Re: [PATCH v2 net] ipv4: Handle attempt to delete multipath route when fib_info contains an nh reference
Date: Thu, 6 Oct 2022 09:11:25 -0600 [thread overview]
Message-ID: <73a235e9-8a9c-a212-719f-15527de359fb@kernel.org> (raw)
In-Reply-To: <20221006150842.9336-1-dsahern@kernel.org>
On 10/6/22 9:08 AM, David Ahern wrote:
> diff --git a/tools/testing/selftests/net/fib_nexthops.sh b/tools/testing/selftests/net/fib_nexthops.sh
> index d5a0dd548989..15556138de76 100755
> --- a/tools/testing/selftests/net/fib_nexthops.sh
> +++ b/tools/testing/selftests/net/fib_nexthops.sh
> @@ -1223,6 +1223,11 @@ ipv4_fcnal()
> log_test $rc 0 "Delete nexthop route warning"
> run_cmd "$IP route delete 172.16.101.1/32 nhid 12"
> run_cmd "$IP nexthop del id 12"
> +
> + run_cmd "$IP nexthop add id 21 via 172.16.1.6 dev veth1"
> + run_cmd "$IP ro add 172.16.101.0/24 nhid 21"
> + run_cmd "$IP ro del 172.16.101.0/24 nexthop via 172.16.1.7 dev veth1 nexthop via 172.16.1.8 dev veth1"
> + log_test $? 1 "Delete multipath route with only nh id based entry"
> }
>
> ipv4_grp_fcnal()
Did not intend to add this chunk to v2; it was hanging around the
branch. :-)
The return code check is wrong - should be 2, not 1. I will send a v3
later today.
prev parent reply other threads:[~2022-10-06 15:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-06 15:08 [PATCH v2 net] ipv4: Handle attempt to delete multipath route when fib_info contains an nh reference David Ahern
2022-10-06 15:11 ` David Ahern [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73a235e9-8a9c-a212-719f-15527de359fb@kernel.org \
--to=dsahern@kernel.org \
--cc=davem@davemloft.net \
--cc=exsociety@gmail.com \
--cc=idosch@idosch.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).