From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B9BAC4361B for ; Thu, 17 Dec 2020 02:09:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BCD4623716 for ; Thu, 17 Dec 2020 02:09:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726354AbgLQCJc (ORCPT ); Wed, 16 Dec 2020 21:09:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35480 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727154AbgLQCJ2 (ORCPT ); Wed, 16 Dec 2020 21:09:28 -0500 Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [IPv6:2607:f8b0:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AE5BDC061794 for ; Wed, 16 Dec 2020 18:08:48 -0800 (PST) Received: by mail-pl1-x632.google.com with SMTP id t6so14257011plq.1 for ; Wed, 16 Dec 2020 18:08:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=A4+FzcbcwJRZytxJDlKtjCsziKZBFBeTFiNSiM+M/uc=; b=icIfwfPnUBiETMNKgx00NDR3paFi0rqGdkGSX7Ay73KBH4V+JIDXkN0EktlcXApxdT EtnC/V8sgpFo3HgLkmxy37Ve/T4Wu2UX/NHRWfTAVKBwFPb5LU9y+RHhfO4mhsWQpmxG MN+XkOKhGKJc9mEp0PfwY9EHbl08DPqQL/oV8W8/b0GgrQO83NABLEwGJYZ+7QyYt3Cz BmKSzdWFT4dgz1BmWM1GN351ZIqUlKHbJhGdObrl5q/I/BdY6GGG0zt6T+mGKbKL48cz dO8voBQGmW3xK2NR6b7+8htWHt9CEos4a8E1Nb/97eyMB9DxaPxcbIIE3kXBLzdTz5C2 fvbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=A4+FzcbcwJRZytxJDlKtjCsziKZBFBeTFiNSiM+M/uc=; b=NmP4EZyQkfHovEJWKXtM1ndDft1IL0kgWVMxL1lxk6LzBdjwu2LbpyTO0ecX//fFjk 2Ftl/pK97wiyrEKXEaRYWg3hRZKrZyOChvN4ZSbQ+yBNYVYE58lU42qfrVDINhGAfXbN Aa8OxgHR1EVtIVnx/p1zkido+tU9PPpFPvFfcV3BqjfN6t8BTSj7Ln3WXKpaNpj5NuiS 3uCXyoxL8K5Ys7b6M63MFi6mYKrBAle4FPuZnqRQM9eDEPINi5KC4pcPr4A+I8pkW/nu Eh694xRLOAMnyEKjyoDMXFIvGL6/njdmzX8O6a7/i3ducClw9F5IyX75iIrOlvNwb+9L KTfQ== X-Gm-Message-State: AOAM531wQHYUMcB0TcXOKy4oqdt2yRQgK7ejslZSjW+SgQ/IQMYEPmZu pPkcpEbtllULCPXjRpLRSEI= X-Google-Smtp-Source: ABdhPJwo2pi9L/u/wvNE0DPcB9PAans3E6KJLdZS9qwVZ0Nmevloy7DivoV9TMp1NDfH+/+5NH0SsQ== X-Received: by 2002:a17:90a:c82:: with SMTP id v2mr5577865pja.171.1608170928263; Wed, 16 Dec 2020 18:08:48 -0800 (PST) Received: from [10.230.29.166] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id cl23sm3229790pjb.23.2020.12.16.18.08.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Dec 2020 18:08:47 -0800 (PST) Subject: Re: [RFC PATCH net-next 5/9] net: dsa: remove the transactional logic from MDB entries To: Vladimir Oltean , "David S. Miller" , Jakub Kicinski , netdev@vger.kernel.org Cc: Andrew Lunn , Vivien Didelot , Vladimir Oltean , Kurt Kanzenbach , Hauke Mehrtens , Woojung Huh , Microchip Linux Driver Support , Sean Wang , Landen Chao , Claudiu Manoil , Alexandre Belloni , Linus Walleij , Vadym Kochan , Taras Chornyi , Jiri Pirko , Ido Schimmel , Grygorii Strashko , Ioana Ciornei , Ivan Vecera References: <20201217015822.826304-1-vladimir.oltean@nxp.com> <20201217015822.826304-6-vladimir.oltean@nxp.com> From: Florian Fainelli Message-ID: <73b1ac8b-11fd-0494-310b-cea4ef476647@gmail.com> Date: Wed, 16 Dec 2020 18:08:44 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20201217015822.826304-6-vladimir.oltean@nxp.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 12/16/2020 5:58 PM, Vladimir Oltean wrote: > For many drivers, the .port_mdb_prepare callback was not a good opportunity > to avoid any error condition, and they would suppress errors found during > the actual commit phase. > > Where a logical separation between the prepare and the commit phase > existed, the function that used to implement the .port_mdb_prepare > callback still exists, but now it is called directly from .port_mdb_add, > which was modified to return an int code. > > Signed-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli -- Florian