* [PATCH][next] net: dsa: mv88e6xxx: make const read-only array lanes static
@ 2023-09-19 9:40 Colin Ian King
2023-09-19 14:38 ` Andrew Lunn
2023-09-20 11:00 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Colin Ian King @ 2023-09-19 9:40 UTC (permalink / raw)
To: Andrew Lunn, Florian Fainelli, Vladimir Oltean, David S . Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, netdev
Cc: kernel-janitors, linux-kernel
Don't populate the const read-only array lanes on the stack, instead make
it static.
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
drivers/net/dsa/mv88e6xxx/pcs-639x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/dsa/mv88e6xxx/pcs-639x.c b/drivers/net/dsa/mv88e6xxx/pcs-639x.c
index ba373656bfe1..9a8429f5d09c 100644
--- a/drivers/net/dsa/mv88e6xxx/pcs-639x.c
+++ b/drivers/net/dsa/mv88e6xxx/pcs-639x.c
@@ -208,7 +208,7 @@ static void mv88e639x_sgmii_pcs_pre_config(struct phylink_pcs *pcs,
static int mv88e6390_erratum_3_14(struct mv88e639x_pcs *mpcs)
{
- const int lanes[] = { MV88E6390_PORT9_LANE0, MV88E6390_PORT9_LANE1,
+ static const int lanes[] = { MV88E6390_PORT9_LANE0, MV88E6390_PORT9_LANE1,
MV88E6390_PORT9_LANE2, MV88E6390_PORT9_LANE3,
MV88E6390_PORT10_LANE0, MV88E6390_PORT10_LANE1,
MV88E6390_PORT10_LANE2, MV88E6390_PORT10_LANE3 };
--
2.39.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH][next] net: dsa: mv88e6xxx: make const read-only array lanes static
2023-09-19 9:40 [PATCH][next] net: dsa: mv88e6xxx: make const read-only array lanes static Colin Ian King
@ 2023-09-19 14:38 ` Andrew Lunn
2023-09-20 11:00 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Lunn @ 2023-09-19 14:38 UTC (permalink / raw)
To: Colin Ian King
Cc: Florian Fainelli, Vladimir Oltean, David S . Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, netdev, kernel-janitors,
linux-kernel
On Tue, Sep 19, 2023 at 10:40:21AM +0100, Colin Ian King wrote:
> Don't populate the const read-only array lanes on the stack, instead make
> it static.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH][next] net: dsa: mv88e6xxx: make const read-only array lanes static
2023-09-19 9:40 [PATCH][next] net: dsa: mv88e6xxx: make const read-only array lanes static Colin Ian King
2023-09-19 14:38 ` Andrew Lunn
@ 2023-09-20 11:00 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-09-20 11:00 UTC (permalink / raw)
To: Colin Ian King
Cc: andrew, f.fainelli, olteanv, davem, edumazet, kuba, pabeni,
netdev, kernel-janitors, linux-kernel
Hello:
This patch was applied to netdev/net-next.git (main)
by David S. Miller <davem@davemloft.net>:
On Tue, 19 Sep 2023 10:40:21 +0100 you wrote:
> Don't populate the const read-only array lanes on the stack, instead make
> it static.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
> drivers/net/dsa/mv88e6xxx/pcs-639x.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Here is the summary with links:
- [next] net: dsa: mv88e6xxx: make const read-only array lanes static
https://git.kernel.org/netdev/net-next/c/ccd663caffc7
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-09-20 11:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-19 9:40 [PATCH][next] net: dsa: mv88e6xxx: make const read-only array lanes static Colin Ian King
2023-09-19 14:38 ` Andrew Lunn
2023-09-20 11:00 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).