From: Tony Nguyen <anthony.l.nguyen@intel.com>
To: Jakub Kicinski <kuba@kernel.org>, <davem@davemloft.net>
Cc: <netdev@vger.kernel.org>, <edumazet@google.com>,
<pabeni@redhat.com>, <jesse.brandeburg@intel.com>
Subject: Re: [PATCH net 2/2] eth: ixgbe: fix the wake condition
Date: Wed, 7 Jun 2023 09:33:14 -0700 [thread overview]
Message-ID: <73c192f9-59b6-77c5-922c-2222b660623f@intel.com> (raw)
In-Reply-To: <20230607010826.960226-2-kuba@kernel.org>
On 6/6/2023 6:08 PM, Jakub Kicinski wrote:
> Flip the netif_carrier_ok() condition in queue wake logic.
> When I moved it to inside __netif_txq_completed_wake()
> I missed negating it.
>
> This made the condition ineffective and could probably
> lead to crashes.
>
> Fixes: 301f227fc860 ("net: piggy back on the memory barrier in bql when waking queues")
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
LGTM
Reviewed-by: Tony Nguyen <anthony.l.nguyen@intel.com>
next prev parent reply other threads:[~2023-06-07 16:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-07 1:08 [PATCH net 1/2] eth: bnxt: fix the wake condition Jakub Kicinski
2023-06-07 1:08 ` [PATCH net 2/2] eth: ixgbe: " Jakub Kicinski
2023-06-07 16:33 ` Tony Nguyen [this message]
2023-06-07 4:34 ` [PATCH net 1/2] eth: bnxt: " Michael Chan
2023-06-08 5:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73c192f9-59b6-77c5-922c-2222b660623f@intel.com \
--to=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jesse.brandeburg@intel.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).