From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56622C7618B for ; Thu, 25 Jul 2019 12:25:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2A615229F9 for ; Thu, 25 Jul 2019 12:25:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729848AbfGYMZQ (ORCPT ); Thu, 25 Jul 2019 08:25:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55852 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726001AbfGYMZQ (ORCPT ); Thu, 25 Jul 2019 08:25:16 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EC059308339B; Thu, 25 Jul 2019 12:25:15 +0000 (UTC) Received: from localhost.localdomain (unknown [10.32.181.77]) by smtp.corp.redhat.com (Postfix) with ESMTP id B3F151001947; Thu, 25 Jul 2019 12:25:14 +0000 (UTC) Message-ID: <73cd7a2a29db5a32d669273d367566cdf6652f4e.camel@redhat.com> Subject: Re: [PATCH net-next 2/2] mlx4/en_netdev: call notifiers when hw_enc_features change From: Davide Caratti To: Saeed Mahameed , "davem@davemloft.net" , Tariq Toukan , "netdev@vger.kernel.org" Cc: Eran Ben Elisha In-Reply-To: References: Organization: red hat Content-Type: text/plain; charset="UTF-8" Date: Thu, 25 Jul 2019 14:25:13 +0200 MIME-Version: 1.0 User-Agent: Evolution 3.30.5 (3.30.5-1.fc29) Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.44]); Thu, 25 Jul 2019 12:25:16 +0000 (UTC) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, 2019-07-24 at 20:47 +0000, Saeed Mahameed wrote: > On Wed, 2019-07-24 at 16:02 +0200, Davide Caratti wrote: > > ensure to call netdev_features_change() when the driver flips its > > hw_enc_features bits. > > > > Signed-off-by: Davide Caratti > > The patch is correct, hello Saeed, and thanks for looking at this! > but can you explain how did you come to this ? > did you encounter any issue with the current code ? > > I am asking just because i think the whole dynamic changing of dev- > > hw_enc_features is redundant since mlx4 has the featutres_check > callback. we need it to ensure that vlan_transfer_features() updates the (new) value of hw_enc_features in the overlying vlan: otherwise, segmentation will happen anyway when skb passes from vxlan to vlan, if the vxlan is added after the vlan device has been created (see: 7dad9937e064 ("net: vlan: add support for tunnel offload") ). thanks! -- davide