From: David Ahern <dsahern@gmail.com>
To: David Miller <davem@davemloft.net>, alexey.kodanev@oracle.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net v2 1/2] rtnetlink: restore handling of dumpit return value in rtnl_dump_all()
Date: Mon, 5 Nov 2018 18:08:16 -0700 [thread overview]
Message-ID: <73e21d98-5d47-2e1b-f2dc-3a33c54a61d1@gmail.com> (raw)
In-Reply-To: <20181105.170619.795988090444501257.davem@davemloft.net>
On 11/5/18 6:06 PM, David Miller wrote:
> From: Alexey Kodanev <alexey.kodanev@oracle.com>
> Date: Fri, 2 Nov 2018 19:11:04 +0300
>
>> For non-zero return from dumpit() we should break the loop
>> in rtnl_dump_all() and return the result. Otherwise, e.g.,
>> we could get the memory leak in inet6_dump_fib() [1]. The
>> pointer to the allocated struct fib6_walker there (saved
>> in cb->args) can be lost, reset on the next iteration.
>>
>> Fix it by partially restoring the previous behavior before
>> commit c63586dc9b3e ("net: rtnl_dump_all needs to propagate
>> error from dumpit function"). The returned error from
>> dumpit() is still passed further.
> ...
>> Fixes: c63586dc9b3e ("net: rtnl_dump_all needs to propagate error from dumpit function")
>> Signed-off-by: Alexey Kodanev <alexey.kodanev@oracle.com>
>
> Applied.
>
Lost track of these in the noise of the past few days.
Thanks for the fixes Alexey.
prev parent reply other threads:[~2018-11-06 10:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-02 16:11 [PATCH net v2 1/2] rtnetlink: restore handling of dumpit return value in rtnl_dump_all() Alexey Kodanev
2018-11-02 16:11 ` [PATCH net v2 2/2] ipv6: properly check return value in inet6_dump_all() Alexey Kodanev
2018-11-06 1:06 ` David Miller
2018-11-06 1:06 ` [PATCH net v2 1/2] rtnetlink: restore handling of dumpit return value in rtnl_dump_all() David Miller
2018-11-06 1:08 ` David Ahern [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73e21d98-5d47-2e1b-f2dc-3a33c54a61d1@gmail.com \
--to=dsahern@gmail.com \
--cc=alexey.kodanev@oracle.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).