From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Ahern Subject: Re: [PATCH net v2 1/2] rtnetlink: restore handling of dumpit return value in rtnl_dump_all() Date: Mon, 5 Nov 2018 18:08:16 -0700 Message-ID: <73e21d98-5d47-2e1b-f2dc-3a33c54a61d1@gmail.com> References: <1541175065-25931-1-git-send-email-alexey.kodanev@oracle.com> <20181105.170619.795988090444501257.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: David Miller , alexey.kodanev@oracle.com Return-path: Received: from mail-pg1-f196.google.com ([209.85.215.196]:41303 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726368AbeKFKav (ORCPT ); Tue, 6 Nov 2018 05:30:51 -0500 Received: by mail-pg1-f196.google.com with SMTP id k13so5027771pga.8 for ; Mon, 05 Nov 2018 17:08:19 -0800 (PST) In-Reply-To: <20181105.170619.795988090444501257.davem@davemloft.net> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 11/5/18 6:06 PM, David Miller wrote: > From: Alexey Kodanev > Date: Fri, 2 Nov 2018 19:11:04 +0300 > >> For non-zero return from dumpit() we should break the loop >> in rtnl_dump_all() and return the result. Otherwise, e.g., >> we could get the memory leak in inet6_dump_fib() [1]. The >> pointer to the allocated struct fib6_walker there (saved >> in cb->args) can be lost, reset on the next iteration. >> >> Fix it by partially restoring the previous behavior before >> commit c63586dc9b3e ("net: rtnl_dump_all needs to propagate >> error from dumpit function"). The returned error from >> dumpit() is still passed further. > ... >> Fixes: c63586dc9b3e ("net: rtnl_dump_all needs to propagate error from dumpit function") >> Signed-off-by: Alexey Kodanev > > Applied. > Lost track of these in the noise of the past few days. Thanks for the fixes Alexey.