From: "Arnd Bergmann" <arnd@arndb.de>
To: "Kees Cook" <keescook@chromium.org>
Cc: "Arnd Bergmann" <arnd@kernel.org>,
"Marcel Holtmann" <marcel@holtmann.org>,
"Johan Hedberg" <johan.hedberg@gmail.com>,
"Luiz Augusto von Dentz" <luiz.dentz@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>, "Chun-Yi Lee" <jlee@suse.com>,
"Luiz Augusto von Dentz" <luiz.von.dentz@intel.com>,
stable@vger.kernel.org,
"Iulia Tanasescu" <iulia.tanasescu@nxp.com>,
"Wenjia Zhang" <wenjia@linux.ibm.com>,
linux-bluetooth@vger.kernel.org, Netdev <netdev@vger.kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Bluetooth: mark bacmp() and bacpy() as __always_inline
Date: Mon, 09 Oct 2023 20:23:08 +0200 [thread overview]
Message-ID: <73f552a4-4ff5-441a-a624-ddc34365742f@app.fastmail.com> (raw)
In-Reply-To: <202310090902.10ED782652@keescook>
On Mon, Oct 9, 2023, at 18:02, Kees Cook wrote:
> On Mon, Oct 09, 2023 at 05:36:55PM +0200, Arnd Bergmann wrote:
>> On Mon, Oct 9, 2023, at 15:48, Arnd Bergmann wrote:
>>
>> Sorry, I have to retract this, something went wrong on my
>> testing and I now see the same problem in some configs regardless
>> of whether the patch is applied or not.
>
> Perhaps turn them into macros instead?
I just tried that and still see the problem even with the macro,
so whatever gcc is doing must be a different issue. Maybe it
has correctly found a codepath that triggers this?
If you are able to help debug the issue better,
see these defconfigs for examples:
https://pastebin.com/raw/pC8Lnrn2
https://pastebin.com/raw/yb965unC
Arnd
next prev parent reply other threads:[~2023-10-09 18:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-09 13:48 [PATCH] Bluetooth: mark bacmp() and bacpy() as __always_inline Arnd Bergmann
2023-10-09 15:36 ` Kees Cook
2023-10-09 15:36 ` Arnd Bergmann
2023-10-09 16:02 ` Kees Cook
2023-10-09 18:23 ` Arnd Bergmann [this message]
2023-10-09 19:48 ` Kees Cook
2023-10-09 20:08 ` Arnd Bergmann
2023-10-09 20:15 ` Kees Cook
2023-10-10 0:01 ` Luiz Augusto von Dentz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73f552a4-4ff5-441a-a624-ddc34365742f@app.fastmail.com \
--to=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=iulia.tanasescu@nxp.com \
--cc=jlee@suse.com \
--cc=johan.hedberg@gmail.com \
--cc=keescook@chromium.org \
--cc=kuba@kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=luiz.von.dentz@intel.com \
--cc=marcel@holtmann.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
--cc=wenjia@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).