From: "Jakub Vaněk" <linuxtardis@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Daniel Golle <daniel@makrotopia.org>,
Qingfang Deng <dqfext@gmail.com>,
SkyLake Huang <SkyLake.Huang@mediatek.com>,
Frank <Frank.Sae@motor-comm.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Sai Krishna <saikrishnag@marvell.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v1] net: phy: motorcomm: yt8821: disable MDIO broadcast address 0
Date: Sun, 22 Feb 2026 05:22:55 +0100 [thread overview]
Message-ID: <740e8351-d8a5-4f4c-91e4-c278e4b7d248@gmail.com> (raw)
In-Reply-To: <3e64d8d1-87c1-45e0-9556-0ca844a90f73@lunn.ch>
On 2/22/26 04:35, Andrew Lunn wrote:
> On Sun, Feb 22, 2026 at 03:32:45AM +0100, Jakub Vaněk wrote:
>> Hello Daniel, Qingfang, SkyLake,
>>
>> do you happen to know if the MediaTek Gigabit PHY in the MT7981B
>> can be remapped to a MDIO address other than address 0?
>>
>> I wasn't able to find public documentation describing the registers
>> of internal PHY or whether its MDIO address is configurable.
>>
>> Being able to move the internal PHY off address 0 in U-Boot could be
>> a better way of resolving a MDIO address conflict between the internal
>> PHY and the broadcast address used by an external Motorcomm YT8821 PHY.
>>
>> Any pointers would be appreciated.
>
> Even if you can avoid the conflict, you still need to handle the fact
> the YT8821 appears on two addresses. phylib has no idea it is the same
> device in two places, so it can instantiate two struct phy_device for
> it. This can cause problems, i think suspend/resume will break, etc.
I had hoped this would not happen on the Cudy router. The MediaTek
Ethernet subsystem driver uses of_mdiobus_register(), so PHY address 0
should not be probed unless it is explicitly described in the device
tree. That said, I agree that with mdiobus_register() this would still
be an issue.
I was also hoping that moving the internal PHY would provide more
flexibility in the device tree description of the YT8821. If the
workaround were implemented in U-Boot by writing YT8821 MDIO registers
at boot time, Linux would not be able to assert the YT8821 reset pin
without losing that workaround.
Jakub
> There is nothing in IEEE 802.3 clause 22 or 45 that allows for this
> behaviour. So rather than living with all the issues it causes, you
> really do want to get the PHY into standards conformance.
>
> Andrew
next prev parent reply other threads:[~2026-02-22 4:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-21 23:46 [PATCH net v1] net: phy: motorcomm: yt8821: disable MDIO broadcast address 0 Jakub Vaněk
2026-02-22 0:16 ` Andrew Lunn
2026-02-23 20:06 ` Jakub Vaněk
2026-02-22 0:18 ` Russell King (Oracle)
2026-02-22 2:04 ` Jakub Vaněk
2026-02-22 2:32 ` Jakub Vaněk
2026-02-22 3:35 ` Andrew Lunn
2026-02-22 4:22 ` Jakub Vaněk [this message]
2026-02-22 8:28 ` Russell King (Oracle)
2026-02-22 9:52 ` Jakub Vaněk
2026-02-22 15:15 ` Andrew Lunn
2026-02-22 19:12 ` Jakub Vaněk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=740e8351-d8a5-4f4c-91e4-c278e4b7d248@gmail.com \
--to=linuxtardis@gmail.com \
--cc=Frank.Sae@motor-comm.com \
--cc=SkyLake.Huang@mediatek.com \
--cc=andrew@lunn.ch \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=dqfext@gmail.com \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saikrishnag@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox