public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: "Michael Büsch" <m@bues.ch>
Cc: netdev@vger.kernel.org, Kalle Valo <kvalo@codeaurora.org>,
	linux-kernel@vger.kernel.org, zajec5@gmail.com,
	Nicolas Ferre <nicolas.ferre@atmel.com>,
	Alexandre Belloni <alexandre.belloni@free-electrons.com>,
	Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>
Subject: Re: [PATCH] ssb: mark ssb_bus_register as __maybe_unused
Date: Tue, 03 Nov 2015 17:42:26 +0100	[thread overview]
Message-ID: <7423389.1hNz9LlOCE@wuerfel> (raw)
In-Reply-To: <20151103172721.04533081@wiggum>

On Tuesday 03 November 2015 17:27:21 Michael Büsch wrote:
> On Tue, 03 Nov 2015 16:05:51 +0100
> Arnd Bergmann <arnd@arndb.de> wrote:
> 
> > The SoC variant of the ssb code is now optional like the other
> > ones, which means we can build the framwork without any
> > front-end, but that results in a warning:
> > 
> > drivers/ssb/main.c:616:12: warning: 'ssb_bus_register' defined but not used [-Wunused-function]
> > 
> > This annotates the ssb_bus_register function as __maybe_unused to
> > shut up the warning. A configuration like this will not work on
> > any hardware of course, but we still want this to silently build
> > without warnings if the configuration is allowed in the first
> > place.
> 
> 
> Is there a simple way to disallow this configuration?

I could not come up with a simple one. We could turn 'CONFIG_SSB' into
a silent option and have it selected by each bus specific driver,
but then we also have to change all the device drivers (usb and
wireless I guess) to use 'depends on' rather than 'select'.

	Arnd

  reply	other threads:[~2015-11-03 16:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-03 15:05 [PATCH] ssb: mark ssb_bus_register as __maybe_unused Arnd Bergmann
2015-11-03 16:27 ` Michael Büsch
2015-11-03 16:42   ` Arnd Bergmann [this message]
2015-11-03 16:51     ` Michael Büsch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7423389.1hNz9LlOCE@wuerfel \
    --to=arnd@arndb.de \
    --cc=alexandre.belloni@free-electrons.com \
    --cc=kvalo@codeaurora.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m@bues.ch \
    --cc=netdev@vger.kernel.org \
    --cc=nicolas.ferre@atmel.com \
    --cc=plagnioj@jcrosoft.com \
    --cc=zajec5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox