From: Shay Agroskin <agrosshay@gmail.com>
To: Michael Chan <michael.chan@broadcom.com>,
Shay Agroskin <shayag@mellanox.com>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"andrew.gospodarek@broadcom.com" <andrew.gospodarek@broadcom.com>,
Tariq Toukan <tariqt@mellanox.com>,
Eran Ben Elisha <eranbe@mellanox.com>,
Saeed Mahameed <saeedm@mellanox.com>
Subject: Re: [PATCH net-next v5 0/5] Introduce NETIF_F_GRO_HW
Date: Sun, 13 Jan 2019 12:36:07 +0200 [thread overview]
Message-ID: <74592992-8949-fd83-158d-7e5f33a82e1a@gmail.com> (raw)
In-Reply-To: <CACKFLikWp55v8kyLOUVKVevHDyjRKAKiBFogPRg393MKyshKDQ@mail.gmail.com>
Thank you for your replies. It answered my questions.
Shay
On 1/8/2019 12:58 PM, Michael Chan wrote:
> On Mon, Jan 7, 2019 at 6:00 AM Shay Agroskin <shayag@mellanox.com> wrote:
>
>> a) All segments (aggregated packets) must be of the same size (except possibly the last one).
>> (This in order to know each segments size, when re-segmenting an aggregated packet)
>>
>> b) IP ID must be incrementing unless DF is
>> (To have the whole 4th layer, in order to know if a packet belongs to a certain flow)
>>
>> c) Also, all the other fields need to be the same to belong to the same flow and be aggregated.
>>
>> Any thoughts? Do I miss anything here ?
> In addition, the GRO SKB needs to be setup properly. For example, the
> gso_type, gso_size, gso_segs, CHECKSUM_PARTIAL, etc, all have to be
> setup. Hardware needs to provide all the necessary information to set
> this up. In case this GRO SKB is re-routed to an output device, TSO
> or GSO needs to be performed on the packet and the original packet
> stream should be re-constituted exactly.
prev parent reply other threads:[~2019-01-13 10:36 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-16 8:09 [PATCH net-next v5 0/5] Introduce NETIF_F_GRO_HW Michael Chan
2017-12-16 8:09 ` [PATCH net-next v5 1/5] net: " Michael Chan
2017-12-16 16:38 ` Alexander Duyck
2017-12-16 8:09 ` [PATCH net-next v5 2/5] net: Disable GRO_HW when generic XDP is installed on a device Michael Chan
2017-12-16 8:09 ` [PATCH net-next v5 3/5] bnxt_en: Use NETIF_F_GRO_HW Michael Chan
2017-12-16 8:09 ` [PATCH net-next v5 4/5] bnx2x: " Michael Chan
2017-12-17 11:49 ` Chopra, Manish
2017-12-16 8:09 ` [PATCH net-next v5 5/5] qede: " Michael Chan
2017-12-17 11:52 ` Chopra, Manish
2017-12-19 15:50 ` [PATCH net-next v5 0/5] Introduce NETIF_F_GRO_HW David Miller
2017-12-19 19:04 ` Marcelo Ricardo Leitner
2017-12-19 19:24 ` David Miller
2017-12-19 19:25 ` Michael Chan
2017-12-19 19:55 ` Marcelo Ricardo Leitner
2017-12-22 14:57 ` Sabrina Dubroca
2017-12-22 18:14 ` Alexander Duyck
2017-12-29 12:43 ` Sabrina Dubroca
2017-12-29 15:12 ` Alexander Duyck
2017-12-30 5:20 ` Michael Chan
2017-12-30 15:45 ` David Miller
2019-01-07 14:00 ` Shay Agroskin
2019-01-07 14:46 ` David Miller
2019-01-08 10:58 ` Michael Chan
2019-01-13 10:36 ` Shay Agroskin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74592992-8949-fd83-158d-7e5f33a82e1a@gmail.com \
--to=agrosshay@gmail.com \
--cc=andrew.gospodarek@broadcom.com \
--cc=davem@davemloft.net \
--cc=eranbe@mellanox.com \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
--cc=shayag@mellanox.com \
--cc=tariqt@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).