From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shay Agroskin Subject: Re: [PATCH net-next v5 0/5] Introduce NETIF_F_GRO_HW Date: Sun, 13 Jan 2019 12:36:07 +0200 Message-ID: <74592992-8949-fd83-158d-7e5f33a82e1a@gmail.com> References: <1513411784-17653-1-git-send-email-michael.chan@broadcom.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: "davem@davemloft.net" , "netdev@vger.kernel.org" , "andrew.gospodarek@broadcom.com" , Tariq Toukan , Eran Ben Elisha , Saeed Mahameed To: Michael Chan , Shay Agroskin Return-path: Received: from mail-wr1-f68.google.com ([209.85.221.68]:43926 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726451AbfAMKgN (ORCPT ); Sun, 13 Jan 2019 05:36:13 -0500 Received: by mail-wr1-f68.google.com with SMTP id r10so19629922wrs.10 for ; Sun, 13 Jan 2019 02:36:12 -0800 (PST) In-Reply-To: Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: Thank you for your replies. It answered my questions. Shay On 1/8/2019 12:58 PM, Michael Chan wrote: > On Mon, Jan 7, 2019 at 6:00 AM Shay Agroskin wrote: > >> a) All segments (aggregated packets) must be of the same size (except possibly the last one). >> (This in order to know each segments size, when re-segmenting an aggregated packet) >> >> b) IP ID must be incrementing unless DF is >> (To have the whole 4th layer, in order to know if a packet belongs to a certain flow) >> >> c) Also, all the other fields need to be the same to belong to the same flow and be aggregated. >> >> Any thoughts? Do I miss anything here ? > In addition, the GRO SKB needs to be setup properly. For example, the > gso_type, gso_size, gso_segs, CHECKSUM_PARTIAL, etc, all have to be > setup. Hardware needs to provide all the necessary information to set > this up. In case this GRO SKB is re-routed to an output device, TSO > or GSO needs to be performed on the packet and the original packet > stream should be re-constituted exactly.