From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E04DC04AA7 for ; Mon, 13 May 2019 17:10:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 09956208C2 for ; Mon, 13 May 2019 17:10:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731282AbfEMRKZ (ORCPT ); Mon, 13 May 2019 13:10:25 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:50755 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731261AbfEMRKZ (ORCPT ); Mon, 13 May 2019 13:10:25 -0400 Received: from c-67-160-6-8.hsd1.wa.comcast.net ([67.160.6.8] helo=famine.localdomain) by youngberry.canonical.com with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.76) (envelope-from ) id 1hQET0-0005K9-0o; Mon, 13 May 2019 17:10:22 +0000 Received: by famine.localdomain (Postfix, from userid 1000) id 000C75FF13; Mon, 13 May 2019 10:10:19 -0700 (PDT) Received: from famine (localhost [127.0.0.1]) by famine.localdomain (Postfix) with ESMTP id ED5F6A6E12; Mon, 13 May 2019 10:10:19 -0700 (PDT) From: Jay Vosburgh To: David Miller cc: jarod@redhat.com, linux-kernel@vger.kernel.org, vfalico@gmail.com, andy@greyhouse.net, netdev@vger.kernel.org Subject: Re: [PATCH] bonding: fix arp_validate toggling in active-backup mode In-reply-to: <20190513.094632.2251179341102416171.davem@davemloft.net> References: <26675.1557528809@famine> <2033e768-9e35-ac89-c526-4c28fc3f747e@redhat.com> <6720.1557765810@famine> <20190513.094632.2251179341102416171.davem@davemloft.net> Comments: In-reply-to David Miller message dated "Mon, 13 May 2019 09:46:32 -0700." X-Mailer: MH-E 8.6+git; nmh 1.6; GNU Emacs 27.0.50 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <7471.1557767419.1@famine> Date: Mon, 13 May 2019 10:10:19 -0700 Message-ID: <7472.1557767419@famine> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org David Miller wrote: >From: Jay Vosburgh >Date: Mon, 13 May 2019 09:43:30 -0700 > >> That would be my preference, as the 29c4948293bf commit looks to >> be the change actually being fixed. > >Sorry I pushed the original commit message out :-( > >But isn't the Fixes: tag he choose the one where the logic actually >causes problems? That's kind of my real criteria for Fixes: tags. I don't think so. It looks like the problem being fixed here (clearing recv_probe when we shouldn't) was introduced at 29c4948293bf, but was not the only place the same problem existed. 3fe68df97c7f fixed the other occurrences of this problem, but missed the specific one added by 29c4948293bf, which is now fixed by this patch. In any event, both of the commits in question are old enough that it's kind of moot, as -stable will presumably get the right thing regardless. -J --- -Jay Vosburgh, jay.vosburgh@canonical.com