From: Denys Fedoryshchenko <nuclearcat@nuclearcat.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: rosenp@gmail.com, Florian Fainelli <f.fainelli@gmail.com>,
netdev@vger.kernel.org, zajec5@gmail.com, nbd@nbd.name,
netdev-owner@vger.kernel.org
Subject: Re: [PATCH] bgmac: Remove all offloading features, including GRO.
Date: Sat, 16 Sep 2017 03:25:59 +0300 [thread overview]
Message-ID: <74955cf749601c3a7a938a6945a976f8@nuclearcat.com> (raw)
In-Reply-To: <1505521095.29839.11.camel@edumazet-glaptop3.roam.corp.google.com>
On 2017-09-16 03:18, Eric Dumazet wrote:
> On Fri, 2017-09-15 at 17:10 -0700, rosenp@gmail.com wrote:
>> Ok fair enough. Will only disable GRO in the driver.
>
> Well, do not even try.
>
> NETIF_F_SOFT_FEATURES is set by core networking stack in
> register_netdevice(), ( commit 212b573f5552c60265da721ff9ce32e3462a2cdd
> )
>
> Absolutely no driver disables GRO (excepts the ones playing with LRO)
I believe also iperf is definitely inconclusive test.
Except iperf there is lot of different workloads and configurations,
that might have different results.
next prev parent reply other threads:[~2017-09-16 0:26 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-15 22:22 [PATCH] bgmac: Remove all offloading features, including GRO Rosen Penev
2017-09-15 22:54 ` Florian Fainelli
2017-09-16 0:03 ` Eric Dumazet
2017-09-16 0:10 ` rosenp
2017-09-16 0:18 ` Eric Dumazet
2017-09-16 0:24 ` rosenp
2017-09-16 0:25 ` Denys Fedoryshchenko [this message]
2017-09-16 3:56 ` David Miller
2017-09-15 23:14 ` David Miller
2017-09-15 23:55 ` rosenp
-- strict thread matches above, loose matches on Subject: below --
2017-09-16 0:23 Rosen Penev
2017-09-16 0:34 ` Eric Dumazet
2017-09-16 0:38 ` rosenp
2017-09-16 6:04 ` Florian Fainelli
2017-09-20 21:27 ` rosenp
2017-09-20 21:32 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74955cf749601c3a7a938a6945a976f8@nuclearcat.com \
--to=nuclearcat@nuclearcat.com \
--cc=eric.dumazet@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=nbd@nbd.name \
--cc=netdev-owner@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rosenp@gmail.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).