From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BDBB3306B37 for ; Thu, 7 May 2026 14:57:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778165827; cv=none; b=JhAHyB/ANmbm0cO5EX8x1Mb3pwBJyJbQMDLG3rOpOG8lKD+V0YA74kIzQPsnPzpJl/XK9TITHI054wzdXl5iWWGARji98Z4+WdCpTsJMKIOkduK0Wh/Kql6DzPc6fMQmGyahGKF/bmE+3qIiXnd3zvU/IWxF+tqmR/jva6kYXAY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778165827; c=relaxed/simple; bh=PvLSEysbifg565g3DA6jS+loymliEvUT/DPan/JtIj8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=fxWgVq+VGV+bc/J1j8YcSLt2N7syBBaFIP/37y21zFx6I88lwjO8gO0CGlKC07hodoAHradFyJtHrLc07q5zjSqKe+5hTX+yac/DuNWphGIeXU0smlsb12p2ifedZ5aGZb4EDpKrPjMhBJiRYNNmfZ6XhyxE9ZwzXcu0YRkzBCg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=eDs9EUZ8; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="eDs9EUZ8" Received: by smtp.kernel.org (Postfix) with ESMTPSA id F36CEC2BCB2; Thu, 7 May 2026 14:57:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778165827; bh=PvLSEysbifg565g3DA6jS+loymliEvUT/DPan/JtIj8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=eDs9EUZ8Bz5yN1EJbllC0ymG+SIounyLI9S/E36E1dOqlrM0/AwtfhYrbVrnK6ipt AJMYDS9kkYC7YKl2V8qdS3U8E1uhQgZ2ct+wGA+MjeVVH8HglufD9xsowrUyRNN/FX pJPXrr5gqFqYDyccCOp9ZGMhOEMDtO4KLYPhvOpVurKyduhJfCMGdtQsuue0Y36S5K lLDtJ4kCRyVKiVSB0N9H4mx1asfASuX7woi1Td0GA/3iKC73ydLJeWLrrJQr+6mbID qrtsRE/bbjhem2h7KMJ6+ObLWDIfM/CP5vOcqsdLrPXinPUd58PSuJ9o0p0gRdF9LC Iko+KIE65J3rg== Message-ID: <749c97fa-9836-47af-a7ee-76b15bf54e21@kernel.org> Date: Thu, 7 May 2026 08:57:06 -0600 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v3 0/3] ipv4: Flush the FIB once on multiple nexthop removal Content-Language: en-US To: Cosmin Ratiu , netdev@vger.kernel.org Cc: Ido Schimmel , Kuniyuki Iwashima , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Simon Horman , Paolo Abeni References: <20260507075606.322405-1-cratiu@nvidia.com> From: David Ahern In-Reply-To: <20260507075606.322405-1-cratiu@nvidia.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5/7/26 1:56 AM, Cosmin Ratiu wrote: > This series optimizes multiple nexthop removal performance from having > to do a FIB flush for each nexthop being removed to only doing a single > FIB flush after all nexthops are removed. > > This dramatically improves performance in scenarios where there are > many nexthops and many ipv4 routes. Please see individual patches for > more details and for a test scenario. > > V2 -> V3: https://lore.kernel.org/netdev/8fea4084-c9ec-472a-b8ab-ecc87e537216@kernel.org/T/#t > - Split the patch into 3 (Ido Schimmel, David Ahern) > - Used WARN_ON_ONCE instead of WARN_ON (Ido Schimmel) > > V1 -> V2: > - Fixes xmas tree in a couple places (Kuniyuki Iwashima) > - Added __must_check to remove_nexthop_from_groups() (Kuniyuki Iwashima) > > Cosmin Ratiu (3): > ipv4: Provide a FIB flushing signal from nexthop removal functions > ipv4: Flush the FIB once on multiple nexthop removal > ipv4: Add __must_check to nexthop removal functions > > net/ipv4/nexthop.c | 88 +++++++++++++++++++++++++++++----------------- > 1 file changed, 56 insertions(+), 32 deletions(-) > Much easier to follow. Thank you. For the set: Reviewed-by: David Ahern