Re: [PATCH net v6 1/4] selftests: Migrate nsim-only MACsec tests to Python

Cosmin Ratiu
2026-04-02T11:51:32Z

On Thu, 2026-04-02 at 12:03 +0200, Sabrina Dubroca wrote:
> 2026-03-30, 16:01:27 +0300, Cosmin Ratiu wrote:
> > -#
> > -# test ethtool features when toggling offload
> > -#
> > -
> > -ip link add link $NSIM_NETDEV $MACSEC_NETDEV type macsec offload
> > mac
> > -TMP_FEATS_ON_1="$(ethtool -k $MACSEC_NETDEV)"
> > -
> > -ip link set $MACSEC_NETDEV type macsec offload off
> > -TMP_FEATS_OFF_1="$(ethtool -k $MACSEC_NETDEV)"
> > -
> > -ip link set $MACSEC_NETDEV type macsec offload mac
> > -TMP_FEATS_ON_2="$(ethtool -k $MACSEC_NETDEV)"
> > -
> > -[ "$TMP_FEATS_ON_1" = "$TMP_FEATS_ON_2" ]
> > -check $?
> [...]
> > -TMP_FEATS_OFF_2="$(ethtool -k $MACSEC_NETDEV)"
> > -[ "$TMP_FEATS_OFF_1" = "$TMP_FEATS_OFF_2" ]
> > -check $?
> [...]
> > -TMP_FEATS_ON_3="$(ethtool -k $MACSEC_NETDEV)"
> > -[ "$TMP_FEATS_ON_1" = "$TMP_FEATS_ON_3" ]
> > -check $?
>
> Those feature comparisons are missing in the new python test. The
> rest
> of the patch looks good.
>

Thanks,
I am not sure why those are missing. I vaguely remember having them at
some point, there were issues, I threw them out thinking there's not
much value in checking that all netdev features don't change (the tests
basically don't deal with only macsec).

I added them back in v7.

Cosmin.