From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Ahern <dsa@cumulusnetworks.com>
Subject: Re: [patch net-next 1/2] devlink: add hardware messages tracing
 facility
Date: Mon, 11 Jul 2016 09:01:46 -0600
Message-ID: <74df1f22-1777-fa69-1a82-cb26388060b8@cumulusnetworks.com>
References: <1468243128-6669-1-git-send-email-jiri@resnulli.us>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Cc: davem@davemloft.net, idosch@mellanox.com, yotamg@mellanox.com,
	eladr@mellanox.com, nogahf@mellanox.com, ogerlitz@mellanox.com,
	ivecera@redhat.com, rostedt@goodmis.org, mingo@redhat.com,
	jolsa@kernel.org
To: Jiri Pirko <jiri@resnulli.us>, netdev@vger.kernel.org
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-io0-f172.google.com ([209.85.223.172]:33514 "EHLO
	mail-io0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S933904AbcGKPBx (ORCPT
	<rfc822;netdev@vger.kernel.org>); Mon, 11 Jul 2016 11:01:53 -0400
Received: by mail-io0-f172.google.com with SMTP id 38so8739706iol.0
        for <netdev@vger.kernel.org>; Mon, 11 Jul 2016 08:01:53 -0700 (PDT)
In-Reply-To: <1468243128-6669-1-git-send-email-jiri@resnulli.us>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On 7/11/16 7:18 AM, Jiri Pirko wrote:

> diff --git a/net/core/devlink.c b/net/core/devlink.c
> index b2e592a..8cfa3b0 100644
> --- a/net/core/devlink.c
> +++ b/net/core/devlink.c
> @@ -26,6 +26,8 @@
>  #include <net/net_namespace.h>
>  #include <net/sock.h>
>  #include <net/devlink.h>
> +#define CREATE_TRACE_POINTS
> +#include <trace/events/devlink.h>

EXPORT_TRACEPOINT_SYMBOL_GPL(trace_devlink_hwmsg);

>
>  static LIST_HEAD(devlink_list);
>
> @@ -1679,6 +1681,13 @@ void devlink_free(struct devlink *devlink)
>  }
>  EXPORT_SYMBOL_GPL(devlink_free);
>
> +void devlink_trace_hwmsg(const struct devlink *devlink, bool incoming,
> +			 unsigned long type, const u8 *buf, size_t len)
> +{
> +	trace_devlink_hwmsg(devlink, incoming, type, buf, len);
> +}
> +EXPORT_SYMBOL_GPL(devlink_trace_hwmsg);

Then you don't need this devlink function.