Netdev List
 help / color / mirror / Atom feed
From: Igor Russkikh <igor.russkikh@aquantia.com>
To: Yunsheng Lin <linyunsheng@huawei.com>,
	"David S . Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org, David Arcari <darcari@redhat.com>,
	Pavel Belous <Pavel.Belous@aquantia.com>,
	Nadezhda Krupnina <Nadezhda.Krupnina@aquantia.com>,
	Simon Edelhaus <simon.edelhaus@aquantia.com>
Subject: Re: [PATCH net 2/4] net:ethernet:aquantia: Fix Tx queue hangups
Date: Thu, 21 Sep 2017 17:31:47 +0300	[thread overview]
Message-ID: <74f2e3bc-e1ef-92cf-d665-5e7abb68ae94@aquantia.com> (raw)
In-Reply-To: <024e7fb3-9b53-f4f2-3901-38a63c47d76c@huawei.com>

Thanks for the comments, Yunsheng,

>>  
>> +static int aq_nic_update_link_status(struct aq_nic_s *self)
>> +{
>> +	int err = self->aq_hw_ops.hw_get_link_status(self->aq_hw);
>> +
>> +	if (err < 0)
>> +		return -1;
> why not just return err?

Agreed, that could be improved.

>> +	if (self->link_status.mbps != self->aq_hw->aq_link_status.mbps)
>> +		pr_info("%s: link change old %d new %d\n",
>> +			AQ_CFG_DRV_NAME, self->link_status.mbps,
>> +			self->aq_hw->aq_link_status.mbps);
> You has ndev in struct aq_nic_s *self, why not use netdev_*?

We are planning to introduce a generic rework commit separately and use netif_* set of macro's through all the driver's code.

-- 
BR, Igor

  reply	other threads:[~2017-09-21 14:32 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-21 10:53 [PATCH net 0/4] net:ethernet:aquantia: Atlantic driver bugfixes and improvements Igor Russkikh
2017-09-21 10:53 ` [PATCH net 1/4] net:ethernet:aquantia: Setup max_mtu in ndev to enable jumbo frames Igor Russkikh
2017-09-21 15:36   ` Andrew Lunn
2017-09-22  7:24     ` Igor Russkikh
2017-09-21 10:53 ` [PATCH net 2/4] net:ethernet:aquantia: Fix Tx queue hangups Igor Russkikh
2017-09-21 11:19   ` Yunsheng Lin
2017-09-21 14:31     ` Igor Russkikh [this message]
2017-09-21 10:53 ` [PATCH net 3/4] net:ethernet:aquantia: Fix transient invalid link down/up indications Igor Russkikh
2017-09-21 15:38   ` Andrew Lunn
2017-09-21 10:53 ` [PATCH net 4/4] net:ethernet:atlantic: fix iommu errors Igor Russkikh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=74f2e3bc-e1ef-92cf-d665-5e7abb68ae94@aquantia.com \
    --to=igor.russkikh@aquantia.com \
    --cc=Nadezhda.Krupnina@aquantia.com \
    --cc=Pavel.Belous@aquantia.com \
    --cc=darcari@redhat.com \
    --cc=davem@davemloft.net \
    --cc=linyunsheng@huawei.com \
    --cc=netdev@vger.kernel.org \
    --cc=simon.edelhaus@aquantia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox