From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Fastabend Subject: Re: [bpf PATCH 0/4] sockhash/sockmap fixes Date: Thu, 5 Jul 2018 08:48:00 -0700 Message-ID: <7517e48f-9e1d-1d58-0581-be00e040aa63@gmail.com> References: <20180705152803.15312.47795.stgit@john-Precision-Tower-5810> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: ast@kernel.org, daniel@iogearbox.net Return-path: Received: from mail-io0-f193.google.com ([209.85.223.193]:44309 "EHLO mail-io0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753690AbeGEPsP (ORCPT ); Thu, 5 Jul 2018 11:48:15 -0400 Received: by mail-io0-f193.google.com with SMTP id q19-v6so8161443ioh.11 for ; Thu, 05 Jul 2018 08:48:15 -0700 (PDT) In-Reply-To: <20180705152803.15312.47795.stgit@john-Precision-Tower-5810> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 07/05/2018 08:36 AM, John Fastabend wrote: > First three patches resolve issues found while testing sockhash and > reviewing code. Syzbot also found them about the same time as I was > working on fixes. The main issue is in the sockhash path we reduced > the scope of sk_callback lock but this meant we could get update and > close running in parallel so fix that here. [...] > --- > > John Fastabend (4): > bpf: fix sk_skb programs without skb->dev assigned > bpf: sockhash, disallow bpf_tcp_close and update in parallel > bpf: sockmap, consume_skb in close path > bpf: sockmap, convert bpf_compute_data_pointers to bpf_*_sk_skb > > > 0 files changed ^^^^^^^^^^^^^^^ Ah dang, something about my workflow causes git to report 0 files changed occasionally, I forgot to check it before sending. I'll send a v2. And get some more coffee I guess. Thanks sorry for the noise.