From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.ionic.de (ionic.de [145.239.234.145]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3DD982D3A66; Tue, 12 Aug 2025 01:35:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=145.239.234.145 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754962561; cv=none; b=meg8Y9NiDyj2Tc1d34XneBZTHp6EDTZU0+XtxN3An6QeS0Jolw/l3ngccYjiKImFhEqS8sC5yfmaTHexgO/D+jOweQb2G0RH5jVgBPY+bWsGML2ti7na9sNoLOZNBoGqwZpfRqpV9pbsaVQgiRKVGtlTA7KSZ5dk9cOL4houfx8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754962561; c=relaxed/simple; bh=+27GkfYyVEkq3Awzc3j7QyAtaRQjn4gyZlZret25di4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=WD0EfTqn3YZkKSWalaQ8Ca8LCfiAk5aU4qO9p+iLhxnesbsZob65PNMKQcSK4yS6IRRLrv9Nr237LydRHfyiqbEoSziNY5YQ+IqVcDaIheXQihQJh2CxK48+Ehx4gCilWQ3+6MSqmkSMX89qj/kPkYj4YDuEUa4NkAp+8aJIiWI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ionic.de; spf=pass smtp.mailfrom=ionic.de; dkim=pass (1024-bit key) header.d=ionic.de header.i=@ionic.de header.b=jLz5upYe; arc=none smtp.client-ip=145.239.234.145 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ionic.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ionic.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ionic.de header.i=@ionic.de header.b="jLz5upYe" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ionic.de; s=default; t=1754962551; bh=+27GkfYyVEkq3Awzc3j7QyAtaRQjn4gyZlZret25di4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jLz5upYeKcxTKvdO9qRSe3opwVkMnqJ7Too7nUK44ONVsT0jGLCockWgAfR2I3VUp /yHMHsjuC6PcZ8V2gnEVK0yd/9vhar5FmJxRpXqEPNzhZ1QeDOifEwbLzTJN941ewy 4h+hO45vxde76IkkSWW+TsAleHVmRuAkOJ1RQ6Jw= Received: from grml.local.home.ionic.de (unknown [IPv6:2a00:11:fb41:7a00:21b:21ff:fe5e:dddc]) by mail.ionic.de (Postfix) with ESMTPSA id D1341148A06D; Tue, 12 Aug 2025 03:35:50 +0200 (CEST) From: Mihai Moldovan To: linux-arm-msm@vger.kernel.org, Manivannan Sadhasivam Cc: Denis Kenzior , Eric Dumazet , Kuniyuki Iwashima , Paolo Abeni , Willem de Bruijn , "David S . Miller" , Jakub Kicinski , Simon Horman , linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH v5 11/11] net: qrtr: mhi: Report endpoint id in sysfs Date: Tue, 12 Aug 2025 03:35:37 +0200 Message-ID: <7521f1c059bfc778614d5f5f748a776db5cc498c.1754962437.git.ionic@ionic.de> X-Mailer: git-send-email 2.50.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Denis Kenzior Add a read-only 'endpoint' sysfs entry that contains the qrtr endpoint identifier assigned to this mhi device. Can be used to direct / receive qrtr traffic only from a particular MHI device. Signed-off-by: Denis Kenzior Reviewed-by: Marcel Holtmann Reviewed-by: Andy Gross Signed-off-by: Mihai Moldovan --- v5: - no changes - Link to v4: https://msgid.link/462b6599fc713e8ee0950f08a5a176f12eb74555.1753720935.git.ionic@ionic.de v4: - no changes - Link to v3: https://msgid.link/e1f5b82cd25b2ac433b1bd7e83e22604e6b24f03.1753313000.git.ionic@ionic.de v3: - rebase against current master - Link to v2: https://msgid.link/1a49dec96d5c2c5258c9df935d8c9381793d4ddd.1752947108.git.ionic@ionic.de v2: - rebase against current master - use %u formatter instead of %d when printing endpoint id (u32) as per review comment - Link to v1: https://msgid.link/20241018181842.1368394-11-denkenz@gmail.com --- net/qrtr/mhi.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/net/qrtr/mhi.c b/net/qrtr/mhi.c index 69f53625a049..9a23c888e234 100644 --- a/net/qrtr/mhi.c +++ b/net/qrtr/mhi.c @@ -72,6 +72,16 @@ static int qcom_mhi_qrtr_send(struct qrtr_endpoint *ep, struct sk_buff *skb) return rc; } +static ssize_t endpoint_show(struct device *dev, + struct device_attribute *attr, char *buf) +{ + struct qrtr_mhi_dev *qdev = dev_get_drvdata(dev); + + return sprintf(buf, "%u\n", qdev->ep.id); +} + +static DEVICE_ATTR_RO(endpoint); + static int qcom_mhi_qrtr_probe(struct mhi_device *mhi_dev, const struct mhi_device_id *id) { @@ -91,6 +101,9 @@ static int qcom_mhi_qrtr_probe(struct mhi_device *mhi_dev, if (rc) return rc; + if (device_create_file(&mhi_dev->dev, &dev_attr_endpoint) < 0) + dev_err(qdev->dev, "Failed to create endpoint attribute\n"); + /* start channels */ rc = mhi_prepare_for_transfer_autoqueue(mhi_dev); if (rc) { @@ -107,6 +120,7 @@ static void qcom_mhi_qrtr_remove(struct mhi_device *mhi_dev) { struct qrtr_mhi_dev *qdev = dev_get_drvdata(&mhi_dev->dev); + device_remove_file(&mhi_dev->dev, &dev_attr_endpoint); qrtr_endpoint_unregister(&qdev->ep); mhi_unprepare_from_transfer(mhi_dev); dev_set_drvdata(&mhi_dev->dev, NULL); -- 2.50.0